chrome/browser/chromeos/accessibility/accessibility_manager.cc - Issue 226663003: Allow content script insertion on about:-URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_manager.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address reviewer's comments (matches->match) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/accessibility/accessibility_manager.cc

diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_manager.cc

index a15a66c63850de4f290556253d128ed205a67536..f2b3c7c87d6dc7475797d17247b0c91df6474c53 100644

--- a/chrome/browser/chromeos/accessibility/accessibility_manager.cc

+++ b/chrome/browser/chromeos/accessibility/accessibility_manager.cc

@@ -133,6 +133,7 @@ class ContentScriptLoader {

params.code = data;

params.run_at = extensions::UserScript::DOCUMENT_IDLE;

params.all_frames = true;

+ params.match_about_blank = false;

params.in_main_world = false;

RenderViewHost* render_view_host =

@@ -172,6 +173,7 @@ void LoadChromeVoxExtension(Profile* profile,

params.code = "window.INJECTED_AFTER_LOAD = true;";

params.run_at = extensions::UserScript::DOCUMENT_IDLE;

params.all_frames = true;

+ params.match_about_blank = false;

params.in_main_world = false;

render_view_host->Send(new ExtensionMsg_ExecuteCode(

render_view_host->GetRoutingID(), params));