extensions/common/user_script.cc - Issue 226663003: Allow content script insertion on about:-URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/user_script.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use matches_about_blank key instead of about:* permission. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/user_script.cc

diff --git a/extensions/common/user_script.cc b/extensions/common/user_script.cc

index 84c1236c604045ee0e8dc82ecdafa9556918364a..8eab76b827b016bd4e034428c62af862570d0a64 100644

--- a/extensions/common/user_script.cc

+++ b/extensions/common/user_script.cc

@@ -127,6 +127,7 @@ void UserScript::Pickle(::Pickle* pickle) const {

pickle->WriteString(extension_id());

pickle->WriteBool(emulate_greasemonkey());

pickle->WriteBool(match_all_frames());

+ pickle->WriteBool(match_about_blank());

pickle->WriteBool(is_incognito_enabled());

PickleGlobs(pickle, globs_);

@@ -175,6 +176,7 @@ void UserScript::Unpickle(const ::Pickle& pickle, PickleIterator* iter) {

CHECK(pickle.ReadString(iter, &extension_id_));

CHECK(pickle.ReadBool(iter, &emulate_greasemonkey_));

CHECK(pickle.ReadBool(iter, &match_all_frames_));

+ CHECK(pickle.ReadBool(iter, &match_about_blank_));

CHECK(pickle.ReadBool(iter, &incognito_enabled_));

UnpickleGlobs(pickle, iter, &globs_);