chrome/common/extensions/api/tabs.json - Issue 226663003: Allow content script insertion on about:-URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/tabs.json

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use matches_about_blank key instead of about:* permission. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/user_script_master_unittest.cc ('K') | « chrome/browser/extensions/user_script_master_unittest.cc ('k') | chrome/common/extensions/docs/templates/articles/content_scripts.html » ('j') | chrome/common/extensions/docs/templates/articles/content_scripts.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/tabs.json

diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json

index 3bd8a5719bfbed4d5b4abd8ca89b0c80166bd818..f715cf761be693eed4c27107c1e746fa0e5dd38e 100644

--- a/chrome/common/extensions/api/tabs.json

+++ b/chrome/common/extensions/api/tabs.json

@@ -38,6 +38,7 @@

"code": {"type": "string", "optional": true, "description": "JavaScript or CSS code to inject."},

"file": {"type": "string", "optional": true, "description": "JavaScript or CSS file to inject."},

"allFrames": {"type": "boolean", "optional": true, "description": "If allFrames is <code>true</code>, implies that the JavaScript or CSS should be injected into all frames of current page. By default, it's <code>false</code> and is only injected into the top frame."},

+ "matchesAboutBlank": {"type": "boolean", "optional": true, "description": "If matchesAboutBlank is true, then the code is also injected in about:blank and about:srcdoc frames if your extension has access to its parent document. Code cannot be inserted in top-level about:-frames. By default it is <code>false</code>."},

not at google - send to devlin 2014/04/21 19:56:22 s/parent/opener ? also, let's make this an action

robwu 2014/04/21 22:15:41 Done.

"runAt": {

"type": "string",

"optional": true,