chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 226663003: Allow content script insertion on about:-URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use matches_about_blank key instead of about:* permission. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 39607d2b0f7f2532c3d2d37871f069edea697e07..4f1816177da8d198d595fc152e2748dc750faf73 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1372,6 +1372,7 @@ bool TabsUpdateFunction::UpdateURL(const std::string &url_string,

ScriptExecutor::JAVASCRIPT,

url.GetContent(),

ScriptExecutor::TOP_FRAME,

+ /* match_about_blank */ true,

not at google - send to devlin 2014/04/21 19:56:22 comment typically goes after the value not before

robwu 2014/04/21 22:15:41 Done.

UserScript::DOCUMENT_IDLE,

ScriptExecutor::MAIN_WORLD,

ScriptExecutor::DEFAULT_PROCESS,