Allow content script insertion on about:-URLs.

chrome/renderer/extensions/user_script_slave_browsertest.cc

Index: chrome/renderer/extensions/user_script_slave_browsertest.cc
diff --git a/chrome/renderer/extensions/user_script_slave_browsertest.cc b/chrome/renderer/extensions/user_script_slave_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..583f4b350a4b6885c0a132ba9761372737f064e9
--- /dev/null
+++ b/chrome/renderer/extensions/user_script_slave_browsertest.cc
@@ -0,0 +1,89 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/extensions/user_script_slave.h"
+#include "content/public/test/render_view_test.h"
+#include "third_party/WebKit/public/web/WebDocument.h"
+#include "url/gurl.h"
+
+using blink::WebFrame;
+using extensions::UserScriptSlave;
+
+namespace {
+
+class UserScriptSlaveTest : public content::RenderViewTest {
+ protected:
+  GURL GetEffectiveDocumentURL(const WebFrame* frame) {
+    return UserScriptSlave::GetEffectiveDocumentURL(
+        frame, frame->document().url(), true);
+  }
+};
+
+}  // namespace
+
+TEST_F(UserScriptSlaveTest, GetEffectiveDocumentURL) {
+  GURL top_url("http://example.com/");
+  GURL different_url("http://example.net/");
+  GURL blank_url("about:blank");
+  GURL srcdoc_url("about:srcdoc");
+
+  const char frame_html[] =
+      "<iframe name='frame1' srcdoc=\""
+      "  <iframe name='frame1_1'></iframe>"
+      "  <iframe name='frame1_2' sandbox=''></iframe>"
+      "\"></iframe>"
+      "<iframe name='frame2' sandbox='' srcdoc=\""
+      "  <iframe name='frame2_1'></iframe>"
+      "\"></iframe>"
+      "<iframe name='frame3'></iframe>";
+
+  const char frame3_html[] = "<iframe name='frame3_1'></iframe>";
+
+  WebFrame* frame = GetMainFrame();
+  ASSERT_TRUE(frame);
+
+  frame->loadHTMLString(frame_html, top_url);
+  do {
+    ProcessPendingMessages();
+  } while (frame->isLoading());
+
+  WebFrame* frame1 = frame->findChildByName("frame1");
+  ASSERT_TRUE(frame1);
+  WebFrame* frame1_1 = frame1->findChildByName("frame1_1");
+  ASSERT_TRUE(frame1_1);
+  WebFrame* frame1_2 = frame1->findChildByName("frame1_2");
+  ASSERT_TRUE(frame1_2);
+  WebFrame* frame2 = frame->findChildByName("frame2");
+  ASSERT_TRUE(frame2);
+  WebFrame* frame2_1 = frame2->findChildByName("frame2_1");
+  ASSERT_TRUE(frame2_1);
+  WebFrame* frame3 = frame->findChildByName("frame3");
+  ASSERT_TRUE(frame3);
+
+  // Load a blank document in a frame from a different origin.
+  frame3->loadHTMLString(frame3_html, different_url);
+  ProcessPendingMessages();

[dcheng, 2014/05/08 00:26:05]

How come we call ProcessPendingMessages in a loop above, but not here? Also,
does this still work if you change useThreadedHTMLParserForDataURLs's initial
setting (in third_party/WebKit/Source/core/frame/Settings.in) to true?

[robwu, 2014/05/08 12:44:10]

I honestly don't know why calling this method once is enough, but wrapping in a
loop does not do any harm, and could prevent test failures in case the messages
have to be pumped more often, so I have submitted a patch set that wraps this
line in a loop.

Changing |useThreadedHTMLParserForDataURLs| did not change the test behavior,
probably because the test does not use data-URIs.

+
+  WebFrame* frame3_1 = frame->findChildByName("frame3");
+  ASSERT_TRUE(frame3_1);
+
+  // Top-level frame
+  EXPECT_EQ(GetEffectiveDocumentURL(frame), top_url);
+  // top -> srcdoc = inherit
+  EXPECT_EQ(GetEffectiveDocumentURL(frame1), top_url);
+  // top -> srcdoc -> about:blank = inherit
+  EXPECT_EQ(GetEffectiveDocumentURL(frame1_1), top_url);
+  // top -> srcdoc -> about:blank sandboxed = same URL
+  EXPECT_EQ(GetEffectiveDocumentURL(frame1_2), blank_url);
+
+  // top -> srcdoc [sandboxed] = same URL
+  EXPECT_EQ(GetEffectiveDocumentURL(frame2), srcdoc_url);
+  // top -> srcdoc [sandboxed] -> about:blank = same URL
+  EXPECT_EQ(GetEffectiveDocumentURL(frame2_1), blank_url);
+
+  // top -> different origin = different origin
+  EXPECT_EQ(GetEffectiveDocumentURL(frame3), different_url);
+  // top -> different origin -> about:blank = inherit
+  EXPECT_EQ(GetEffectiveDocumentURL(frame3_1), different_url);
+}