Allow content script insertion on about:-URLs.

extensions/common/permissions/permissions_data.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/permissions/permissions_data.h"
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 493 matching lines @@
   }
 
   bool can_access = false;
 
   if (script) {
     // If a script is specified, use its matches.
     can_access = script->MatchesURL(document_url);
   } else {
     // Otherwise, see if this extension has permission to execute script
     // programmatically on pages.
-    can_access = GetActivePermissions(extension)->
-        HasExplicitAccessToOrigin(document_url);
+    can_access =
+        GetActivePermissions(extension)->HasEffectiveAccessToURL(document_url);

[not at google - send to devlin, 2014/05/01 20:32:19]

why do you need this change? there isn't a script, so we check against the
explicit host permissions. that is the right thing to do, not checking against
all permissions.

[robwu, 2014/05/01 21:30:38]

The change is not needed any more, so I've reverted it.

My reasoning for not having reverted the change earlier is that if an extension
has declared a content script for a page, then it should also be able to
programatically insert a content script using chrome.tabs.executeScript.

[not at google - send to devlin, 2014/05/02 16:01:48]

Understood. We try to keep the permissions as narrow as possible.

   }
 
   if (!can_access && error) {
     *error = ErrorUtils::FormatErrorMessage(errors::kCannotAccessPage,
                                             document_url.spec());
   }
 
   return can_access;
 }
 
@@ skipping 82 matching lines @@
       initial_optional_permissions_->api_permissions,
       initial_optional_permissions_->manifest_permissions,
       initial_optional_permissions_->host_permissions,
       URLPatternSet());
 
   initial_required_permissions_.reset();
   initial_optional_permissions_.reset();
 }
 
 }  // namespace extensions