Allow content script insertion on about:-URLs.

chrome/renderer/extensions/user_script_slave.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/user_script_slave.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 20 matching lines @@
 #include "third_party/WebKit/public/web/WebDataSource.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebSecurityOrigin.h"
 #include "third_party/WebKit/public/web/WebSecurityPolicy.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "url/gurl.h"
 
 using blink::WebFrame;
+using blink::WebDocument;
 using blink::WebSecurityOrigin;
 using blink::WebSecurityPolicy;
 using blink::WebString;
 using blink::WebVector;
 using blink::WebView;
 using content::RenderThread;
 
 namespace extensions {
 
 // These two strings are injected before and after the Greasemonkey API and
@@ skipping 136 matching lines @@
   // the compose iframe's dataSource URL is about:blank, but the document URL
   // changes to match the parent document after Gmail document.writes into
   // it to create the editor.
   // http://code.google.com/p/chromium/issues/detail?id=86742
   blink::WebDataSource* data_source = frame->provisionalDataSource() ?
       frame->provisionalDataSource() : frame->dataSource();
   CHECK(data_source);
   return GURL(data_source->request().url());
 }
 
+GURL UserScriptSlave::GetEffectiveDocumentURL(const WebFrame* frame,
+                                              const GURL& document_url,
+                                              bool match_about_blank) {
+  if (!match_about_blank || !document_url.SchemeIs(content::kAboutScheme))
+    return document_url;
+
+  // Scripts on about:blank and about:srcdoc can access their parent document,
+  // so traverse the document tree until a non-about:blank frame is found.
+  WebDocument originDocument = frame->document();
+  const WebSecurityOrigin securityOrigin = originDocument.securityOrigin();

[not at google - send to devlin, 2014/05/01 20:32:19]

security_origin

[robwu, 2014/05/01 21:30:38]

Done. Should I also use underscores for |parentDocument| and
|parentDocumentUrl|?

[not at google - send to devlin, 2014/05/02 16:01:48]

yep, thanks. always underscore style in Chromium (unless forced to camel case to
implement a Blink API).

+  WebFrame* parent = frame->parent() ? frame->parent() : frame->opener();

[not at google - send to devlin, 2014/05/01 20:32:19]

nit: this big block is hard to read, perhaps a blank line here will help

+  // Note: The next loop body is usually run at most once. It is only repeated
+  // when an about:-frame is embedded in another about:-frame.
+  while (parent != NULL) {

[not at google - send to devlin, 2014/05/01 20:32:19]

i think this loop, whole function really, could be simpler if this condition
were document_url.SchemeIs(content::kAboutScheme). you should only need to check
that once (not twice) and you should only really need to get the parent/opener
document once. i would find the logic here a bit easier to follow in that case.

+    WebDocument parentDocument = parent->document();
+    // Immediately stop traversing the document hierarchy when the page does
+    // not have the permission to access its parent document.
+    if (!securityOrigin.canAccess(parentDocument.securityOrigin()))
+      return document_url;
+
+    // Return the first accessible non-about: URL if found.
+    GURL parentDocumentUrl(parentDocument.url());
+    if (!parentDocumentUrl.SchemeIs(content::kAboutScheme))
+      return parentDocumentUrl;
+
+    originDocument = parentDocument;

[not at google - send to devlin, 2014/05/01 20:32:19]

you don't use this variable inside nor after the loop, so this assignment is
unnecessary.

so storing originDocument in a variable rather than just securityOrigin is
unnecessary.

+    parent = parent->parent() ? parent->parent() : parent->opener();
+  }
+  // A standalone top-level document, just return the original URL.
+  return document_url;
+}
+
 void UserScriptSlave::InjectScripts(WebFrame* frame,
                                     UserScript::RunLocation location) {
   GURL data_source_url = GetDataSourceURLForFrame(frame);
   if (data_source_url.is_empty())
     return;
 
   if (frame->isViewSourceModeEnabled())
     data_source_url = GURL(content::kViewSourceScheme + std::string(":") +
                            data_source_url.spec());
 
@@ skipping 10 matching lines @@
     if (frame->parent() && !script->match_all_frames())
       continue;  // Only match subframes if the script declared it wanted to.
 
     const Extension* extension = extensions_->GetByID(script->extension_id());
 
     // Since extension info is sent separately from user script info, they can
     // be out of sync. We just ignore this situation.
     if (!extension)
       continue;
 
+    const GURL& document_url = GetEffectiveDocumentURL(
+        frame, data_source_url, script->match_about_blank());
+
     // Content scripts are not tab-specific.
     const int kNoTabId = -1;
     // We don't have a process id in this context.
     const int kNoProcessId = -1;
     if (!PermissionsData::CanExecuteScriptOnPage(extension,
-                                                 data_source_url,
+                                                 document_url,
                                                  frame->top()->document().url(),
                                                  kNoTabId,
                                                  script,
                                                  kNoProcessId,
                                                  NULL)) {
       continue;
     }
 
     if (location == UserScript::DOCUMENT_START) {
       num_css += script->css_scripts().size();
@@ skipping 75 matching lines @@
   } else if (location == UserScript::DOCUMENT_IDLE) {
     UMA_HISTOGRAM_COUNTS_100("Extensions.InjectIdle_ScriptCount", num_scripts);
     if (num_scripts)
       UMA_HISTOGRAM_TIMES("Extensions.InjectIdle_Time", timer.Elapsed());
   } else {
     NOTREACHED();
   }
 }
 
 }  // namespace extensions