chrome/test/data/extensions/api_test/content_scripts/about_blank_srcdoc/manifest.json - Issue 226663003: Allow content script insertion on about:-URLs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/content_scripts/about_blank_srcdoc/manifest.json

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address reviewer's comments (matches->match) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "about:blank and about:srcdoc",

	3 "version": "1.0",

	4 "manifest_version": 2,

	5 "description": "Tests that content scripts are injected in about:blank and abo ut:srcdoc frames if it has access to the parent frame.",

	6 "background": {

	7 "page": "test.html"

	8 },

	9 "permissions": [":///*"],

	10 "content_scripts": [

	11 {

	12 "matches": [":///*"],
	not at google - send to devlin 2014/04/21 22:34:41 if you test with "permissions" and "matches" that if you test with "permissions" and "matches" that don't overlap I think you'll see that bug I mentioned previously. robwu 2014/04/21 23:21:46 After removing "permissions": [":///"], the bro Show quoted text On 2014/04/21 22:34:41, kalman wrote: > if you test with "permissions" and "matches" that don't overlap I think you'll > see that bug I mentioned previously. After removing "permissions": [":///"], the browser tests still pass.
	13 "match_about_blank": true,

	14 "js": ["content_script.js"],

	15 "all_frames": true

	16 }

	17 ]

	18 }

OLD	NEW