Allow content script insertion on about:-URLs.

chrome/browser/extensions/user_script_master_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/user_script_master.h"
 
 #include <string>
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
@@ skipping 211 matching lines @@
       text, &script));
   ASSERT_EQ("myscript", script.name());
   ASSERT_EQ(1U, script.url_patterns().patterns().size());
   EXPECT_EQ("http://www.google.com/*",
             script.url_patterns().begin()->GetAsString());
   ASSERT_EQ(1U, script.exclude_url_patterns().patterns().size());
   EXPECT_EQ("http://www.google.com/foo*",
             script.exclude_url_patterns().begin()->GetAsString());
 }
 
+TEST_F(UserScriptMasterTest, Parse9) {
+  const std::string text(
+      "// ==UserScript==\n"
+      "// @include about:blank\n"

[not at google - send to devlin, 2014/04/21 19:56:22]

ah. do we really need to make this work for about:blank? does your use case
require user scripts to work?

[robwu, 2014/04/21 22:15:41]

No, my use case does not require about:blank for user scripts. There are very
few user scripts that want to script about:blank, but supporting the feature is
easy (at this point), hence I've added support for it.
I'm neutral towards (not) supporting this feature, so if you'd rather have this
code removed, just say so.

(side note: Does Chrome still intend to support .user.js? Its implementation is
far from compatible with greasemonkey, and installing a user script for the
average user is impossible because of the standard requirement that "extensions"
need to be installed from the CWS.)

+      "// @match http://example.com/*\n"
+      "// ==/UserScript==\n");
+
+  UserScript script;
+  EXPECT_TRUE(
+      UserScriptMaster::ScriptReloader::ParseMetadataHeader(text, &script));
+  ASSERT_EQ(0U, script.globs().size());
+  EXPECT_TRUE(script.match_about_blank());
+}
+
 TEST_F(UserScriptMasterTest, SkipBOMAtTheBeginning) {
   base::FilePath path = temp_dir_.path().AppendASCII("script.user.js");
   const std::string content("\xEF\xBB\xBF alert('hello');");
   size_t written = base::WriteFile(path, content.c_str(), content.size());
   ASSERT_EQ(written, content.size());
 
   UserScript user_script;
   user_script.js_scripts().push_back(UserScript::File(
       temp_dir_.path(), path.BaseName(), GURL()));
 
@@ skipping 26 matching lines @@
   UserScriptMaster::ScriptReloader* script_reloader =
       new UserScriptMaster::ScriptReloader(NULL);
   script_reloader->AddRef();
   script_reloader->LoadUserScripts(&user_scripts);
   script_reloader->Release();
 
   EXPECT_EQ(content, user_scripts[0].js_scripts()[0].GetContent().as_string());
 }
 
 }  // namespace extensions