Allow content script insertion on about:-URLs.

chrome/renderer/extensions/user_script_scheduler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/user_script_scheduler.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
+#include "chrome/common/url_constants.h"
 #include "chrome/renderer/chrome_render_process_observer.h"
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "chrome/renderer/extensions/dispatcher.h"
 #include "chrome/renderer/extensions/dom_activity_logger.h"
 #include "chrome/renderer/extensions/extension_groups.h"
 #include "chrome/renderer/extensions/extension_helper.h"
 #include "chrome/renderer/extensions/user_script_slave.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/v8_value_converter.h"
 #include "extensions/common/error_utils.h"
@@ skipping 157 matching lines @@
     // We recheck access here in the renderer for extra safety against races
     // with navigation.
     //
     // But different frames can have different URLs, and the extension might
     // only have access to a subset of them. For the top frame, we can
     // immediately send an error and stop because the browser process
     // considers that an error too.
     //
     // For child frames, we just skip ones the extension doesn't have access
     // to and carry on.
-    if (!params.is_web_view &&
-        !PermissionsData::CanExecuteScriptOnPage(extension,
-                                                 child_frame->document().url(),
-                                                 frame_->document().url(),
-                                                 extension_helper->tab_id(),
-                                                 NULL,
-                                                 -1,
-                                                 NULL)) {
-      if (child_frame->parent()) {
-        continue;
-      } else {
-        error = ErrorUtils::FormatErrorMessage(
-            manifest_errors::kCannotAccessPage,
-            child_frame->document().url().spec());
-        break;
+    if (!params.is_web_view) {
+      GURL document_url(child_frame->document().url());
+
+      if (document_url.SchemeIs(content::kAboutScheme)) {

[not at google - send to devlin, 2014/04/18 16:04:55]

mention that about: URLs inherit the origin from their creator frames, since
it's pretty subtle and I don't expect most reader are aware of that.

ideally link to the spec.

Incidentally I think the code would be a little cleaner if you pulled this out
into a helper function.

+        GURL document_origin_url(
+            child_frame->document().securityOrigin().toString());
+        if (document_origin_url.is_valid())
+          document_url = document_origin_url;
+      }
+
+      if (!PermissionsData::CanExecuteScriptOnPage(extension,
+                                                   document_url,
+                                                   frame_->document().url(),
+                                                   extension_helper->tab_id(),
+                                                   NULL,
+                                                   -1,
+                                                   NULL)) {
+        if (child_frame->parent()) {
+          continue;
+        } else {
+          error = ErrorUtils::FormatErrorMessage(
+              manifest_errors::kCannotAccessPage,
+              child_frame->document().url().spec());

[not at google - send to devlin, 2014/04/18 16:04:55]

use document_url here.

+          break;
+        }
       }
     }
 
     if (params.is_javascript) {
       WebScriptSource source(WebString::fromUTF8(params.code), params.file_url);
       v8::HandleScope scope(v8::Isolate::GetCurrent());
 
       scoped_ptr<content::V8ValueConverter> v8_converter(
           content::V8ValueConverter::create());
       v8::Local<v8::Value> script_value;
@@ skipping 52 matching lines @@
 
   for (WebFrame* child_frame = parent_frame->firstChild(); child_frame;
        child_frame = child_frame->nextSibling()) {
     frames_vector->push_back(child_frame);
     GetAllChildFrames(child_frame, frames_vector);
   }
   return true;
 }
 
 }  // namespace extensions