Allow content script insertion on about:-URLs.

chrome/common/extensions/chrome_extensions_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/chrome_extensions_client.h"
 
 #include "apps/common/api/generated_schemas.h"
 #include "base/command_line.h"
 #include "chrome/common/extensions/api/generated_schemas.h"
 #include "chrome/common/extensions/chrome_manifest_handlers.h"
@@ skipping 80 matching lines @@
     // Filters out every URL pattern that matches chrome:// scheme.
     if (i->scheme() == content::kChromeUIScheme) {
       // chrome://favicon is the only URL for chrome:// scheme that we
       // want to support. We want to deprecate the "chrome" scheme.
       // We should not add any additional "host" here.
       if (GURL(chrome::kChromeUIFaviconURL).host() != i->host())
         continue;
       messages->insert(PermissionMessage(
           PermissionMessage::kFavicon,
           l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_FAVICON)));
-    } else {
+    } else if (i->scheme() != content::kAboutScheme) {
+      // Don't warn about the about: scheme, because extensions cannot script

[not at google - send to devlin, 2014/04/10 21:12:49]

can we only support about:blank?

+      // these pages unless they have the permission to edit the frame's origin.

[not at google - send to devlin, 2014/04/18 16:04:55]

@jschuh is the origin of a top-level about:blank "null", because that's what I
get in devtools? Why isn't it "about"?

       new_hosts->AddPattern(*i);
     }
   }
 }
 
 void ChromeExtensionsClient::SetScriptingWhitelist(
     const ExtensionsClient::ScriptingWhitelist& whitelist) {
   scripting_whitelist_ = whitelist;
 }
 
@@ skipping 67 matching lines @@
   feature->AddFilter(
       scoped_ptr<SimpleFeatureFilter>(new ChromeChannelFeatureFilter(feature)));
 }
 
 // static
 ChromeExtensionsClient* ChromeExtensionsClient::GetInstance() {
   return g_client.Pointer();
 }
 
 }  // namespace extensions