Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2266573003:
[Extensions] Trim some fat around what we use in generated schemas (Closed)
Description[Extensions] Trim some fat around what we use in generated schemas
The generated extension schemas already omit comments, whitespace, and
descriptions, but we can do more. Specifically, we can also remove
entries for "compiler_options", "nodoc", and "noinline_doc".
BUG=639539
Committed: https://crrev.com/2f7a11754e0362c81d8545e094eb87ee871dd7b4
Cr-Commit-Position: refs/heads/master@{#413499}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Update comment, return copy #
Total comments: 1
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== trimming BUG= ========== to ========== [Extensions] Trim some fat around what we use in generated schemas The generated extension schemas already omit comments, whitespace, and descriptions, but we can do more. Specifically, we can also remove entries for "compiler_options", "nodoc", and "noinline_doc". BUG=639539 ==========
rdevlin.cronin@chromium.org changed reviewers: + lazyboy@chromium.org
https://codereview.chromium.org/2266573003/diff/1/tools/json_schema_compiler/... File tools/json_schema_compiler/cpp_bundle_generator.py (right): https://codereview.chromium.org/2266573003/diff/1/tools/json_schema_compiler/... tools/json_schema_compiler/cpp_bundle_generator.py:27: """Returns a copy of |schema| with "description" fields removed. Whoops - will update this comment.
lgtm. https://codereview.chromium.org/2266573003/diff/1/tools/json_schema_compiler/... File tools/json_schema_compiler/cpp_bundle_generator.py (right): https://codereview.chromium.org/2266573003/diff/1/tools/json_schema_compiler/... tools/json_schema_compiler/cpp_bundle_generator.py:27: """Returns a copy of |schema| with "description" fields removed. On 2016/08/20 00:53:50, Devlin wrote: > Whoops - will update this comment. Acknowledged.
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2266573003/diff/20001/tools/json_schema_compi... File tools/json_schema_compiler/cpp_bundle_generator.py (right): https://codereview.chromium.org/2266573003/diff/20001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:33: ret = copy.deepcopy(schema) Note: I changed this (back) to returning a copy, because I realized we might not want to change the api object itself if it will be used in other compilations.
still lgtm.
The CQ bit was unchecked by rdevlin.cronin@chromium.org
The CQ bit was checked by rdevlin.cronin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Extensions] Trim some fat around what we use in generated schemas The generated extension schemas already omit comments, whitespace, and descriptions, but we can do more. Specifically, we can also remove entries for "compiler_options", "nodoc", and "noinline_doc". BUG=639539 ========== to ========== [Extensions] Trim some fat around what we use in generated schemas The generated extension schemas already omit comments, whitespace, and descriptions, but we can do more. Specifically, we can also remove entries for "compiler_options", "nodoc", and "noinline_doc". BUG=639539 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Extensions] Trim some fat around what we use in generated schemas The generated extension schemas already omit comments, whitespace, and descriptions, but we can do more. Specifically, we can also remove entries for "compiler_options", "nodoc", and "noinline_doc". BUG=639539 ========== to ========== [Extensions] Trim some fat around what we use in generated schemas The generated extension schemas already omit comments, whitespace, and descriptions, but we can do more. Specifically, we can also remove entries for "compiler_options", "nodoc", and "noinline_doc". BUG=639539 Committed: https://crrev.com/2f7a11754e0362c81d8545e094eb87ee871dd7b4 Cr-Commit-Position: refs/heads/master@{#413499} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2f7a11754e0362c81d8545e094eb87ee871dd7b4 Cr-Commit-Position: refs/heads/master@{#413499} |
