Used a BitField to improve packing of AstNode and subclasses

Used a BitField to improve packing of AstNode and subclasses

BUG=

Committed: https://crrev.com/48faea070fa883d1e08dd8cfcb335690c9842864
Cr-Commit-Position: refs/heads/master@{#39502}

[heimbuef, 2016-08-25 07:30:02]

heimbuef@google.com changed reviewers:
+ verwaest@chromium.org

[heimbuef, 2016-08-25 07:30:03]

PTAL

[Toon Verwaest, 2016-08-26 14:55:02]

https://codereview.chromium.org/2266493002/diff/1/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2266493002/diff/1/src/ast/ast.h#newcode364
src/ast/ast.h:364: bit_field_ = ToBooleanTypesField::update(bit_field_, 0);
Huh? why is this 0-9 rather tahn kNextBitFieldIndex?
Update 0 doesn't do anything though. Is this field not used by any other setter
/ not called anymore?

https://codereview.chromium.org/2266493002/diff/1/src/ast/ast.h#newcode2714
src/ast/ast.h:2714: BailoutReason dont_optimize_reason_;
We should probably annotate BailoutReason with uint8_t / uint16_t depending on
what it needs (probably uint8_t). That would avoid using an entire int here,
plus another int for the bool.

https://codereview.chromium.org/2266493002/diff/1/src/ast/ast.h#newcode2715
src/ast/ast.h:2715: bool should_be_used_once_hint_;
bool should_be_used_once_hint_ : 1

[heimbuef, 2016-08-31 17:08:44]

The CQ bit was checked by heimbuef@google.com

[commit-bot: I haz the power, 2016-08-31 17:08:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:08:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 17:08:56]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Toon Verwaest, 2016-08-31 17:21:16]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:21:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Toon Verwaest, 2016-08-31 17:23:30]

https://codereview.chromium.org/2266493002/diff/60001/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2266493002/diff/60001/src/ast/ast.h#newcode220
src/ast/ast.h:220: class NodeTypeField : public BitField<NodeType, 0, 7> {};
Isn't 6 enough? I'd make it 8 or 6 :) Probably 6 if performance allows.

[commit-bot: I haz the power, 2016-08-31 17:25:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 17:25:35]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/11882)

[Toon Verwaest, 2016-08-31 17:36:05]

lgtm

[heimbuef, 2016-09-19 08:07:29]

The CQ bit was checked by heimbuef@google.com

[commit-bot: I haz the power, 2016-09-19 08:07:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 08:09:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 08:09:35]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12958)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12918)

[heimbuef, 2016-09-19 11:21:13]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-09-19 11:21:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2266493002/#ps100001
(title: "Merge branch 'master' into ast-packing")

[commit-bot: I haz the power, 2016-09-19 11:21:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 11:48:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-19 11:48:48]

Description was changed from

==========
Used a BitField to improve packing of AstNode and subclasses

BUG=
==========

to

==========
Used a BitField to improve packing of AstNode and subclasses

BUG=

Committed: https://crrev.com/48faea070fa883d1e08dd8cfcb335690c9842864
Cr-Commit-Position: refs/heads/master@{#39502}
==========

[commit-bot: I haz the power, 2016-09-19 11:48:49]

Patchset 6 (id:??) landed as
https://crrev.com/48faea070fa883d1e08dd8cfcb335690c9842864
Cr-Commit-Position: refs/heads/master@{#39502}