Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2266473003: [Devtools] [Regression fix] Network Requests with data urls (Closed)

Created:
4 years, 4 months ago by allada
Modified:
4 years, 4 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] [Regression fix] Network Requests with data urls Fixed Regression caused from https://codereview.chromium.org/2186753002 which caused network requests from data url parents to cause devtools to throw an exception because there is no host of the parent frame. R=lushnikov BUG=639469, 624494 Committed: https://crrev.com/e34d0a4a39bc5c48d94b4eaa362d64908e891794 Cr-Commit-Position: refs/heads/master@{#413585}

Patch Set 1 : [Devtools] [Regression fix] Network Requests with data urls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/request-name-path.html View 2 chunks +24 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/request-name-path-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
allada
PTL
4 years, 4 months ago (2016-08-19 21:44:51 UTC) #3
allada
PTL
4 years, 4 months ago (2016-08-19 21:44:52 UTC) #4
eostroukhov
I did a search through the diff - looks like similar regression was probably introduced ...
4 years, 4 months ago (2016-08-19 21:51:47 UTC) #5
dgozman
lgtm
4 years, 4 months ago (2016-08-20 02:47:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266473003/40001
4 years, 4 months ago (2016-08-20 03:04:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126437)
4 years, 4 months ago (2016-08-20 04:59:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266473003/40001
4 years, 4 months ago (2016-08-22 16:12:10 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/278189)
4 years, 4 months ago (2016-08-22 19:11:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266473003/40001
4 years, 4 months ago (2016-08-22 19:14:25 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 4 months ago (2016-08-22 23:42:13 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:45:12 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e34d0a4a39bc5c48d94b4eaa362d64908e891794
Cr-Commit-Position: refs/heads/master@{#413585}

Powered by Google App Engine
This is Rietveld 408576698