Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2266453002: Roll src/third_party/libvpx/source/libvpx/ fe4dd4f43..1c07abca1 (7 commits). (Closed)

Created:
4 years, 4 months ago by marpan1
Modified:
4 years, 4 months ago
Reviewers:
Johann, marpan
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/libvpx/source/libvpx/ fe4dd4f43..1c07abca1 (7 commits). https://chromium.googlesource.com/webm/libvpx.git/+log/fe4dd4f43ff6..1c07abca18d2 $ git log fe4dd4f43..1c07abca1 --date=short --no-merges --format='%ad %ae %s' 2016-08-15 marpan vp9 non-rd pickmode: Add limit on newmv-last and golden bias. 2016-08-17 paulwilkins Add casting to fix warning. 2016-08-17 paulwilkins Add {} to try and keep Jenkins happy. 2016-08-16 marpan vp8: Move loopfilter synchronization to end of encode_frame call. 2016-08-12 linfengz NEON asm of vpx_lpf_{horizontal,vertical}_8_dual_neon() 2016-08-10 paulwilkins Change default recode rule for good speed 0 and best. 2016-08-09 paulwilkins Change to recode rules. R=johannkoenig@google.com Committed: https://crrev.com/3b352b0e6ff7180e8ce9f4bd79069a34220bd705 Cr-Commit-Position: refs/heads/master@{#413179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libvpx/source/config/linux/arm64/vpx_dsp_rtcd.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/libvpx/source/config/vpx_version.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
marpan
4 years, 4 months ago (2016-08-19 17:24:40 UTC) #6
Johann
LGTM
4 years, 4 months ago (2016-08-19 17:36:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266453002/1
4 years, 4 months ago (2016-08-19 17:38:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 17:43:41 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b352b0e6ff7180e8ce9f4bd79069a34220bd705 Cr-Commit-Position: refs/heads/master@{#413179}
4 years, 4 months ago (2016-08-19 17:46:15 UTC) #13
sakal-chromium
Can you please revert this CL? Change: 2016-08-16 marpan vp8: Move loopfilter synchronization to end ...
4 years, 4 months ago (2016-08-22 15:36:11 UTC) #14
chromium-reviews
4 years, 4 months ago (2016-08-22 16:57:03 UTC) #15
Message was sent while issue was closed.
Revert of that change is here:
  https://codereview.chromium.org/2261223002/#

On Mon, Aug 22, 2016 at 8:36 AM, <sakal@chromium.org> wrote:

> Can you please revert this CL?
>
> Change: 2016-08-16 marpan vp8: Move loopfilter synchronization to end of
> encode_frame call.
>
> The change breaks
> https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester
>
> WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest
> .MANUAL_TestVideoQualityVp8/1
> (../../chrome/browser/media/webrtc_video_quality_browsertest.cc:344)
> times out.
>
> The test freezes at the end with black screen somewhat flakily (freezes
> most of
> the time).
>
> https://codereview.chromium.org/2266453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698