Upstream iOS implementation of ProfileOAuth2TokenService

components/signin/core/browser/signin_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
 
 #include "base/callback.h"
 #include "components/signin/core/browser/webdata/token_web_data.h"
 
 class PrefService;
 class SigninManagerBase;
 class TokenWebData;
 
 namespace net {
 class CanonicalCookie;
 class URLRequestContextGetter;
 }
 
+#if defined(OS_IOS)
+namespace ios {
+// TODO(msarda): http://crbug.com/358544 Remove this iOS specific code from the
+// core SigninClient.

[Roger Tawa OOO till Jul 10th, 2014/04/10 15:04:08]

Is this a bug you plan to fix soon?  Can you put more info in the bug as to why
this is here now and why you want to eventually remove it :-)

[msarda, 2014/04/10 15:13:36]

No, this is low priority. It was something Colin wanted me to add in here, but
this will become clearer if I need to remove once we do more componentization
and understand what is the best strategy to use for mutli-platform components.

[blundell, 2014/04/10 15:17:58]

Ideally the client wouldn't have anything platform-specific. However, the
situation around ProfileOAuth2TokenService is challenging due the tricky
inheritance issues, and I don't want to block the high-value work of upstreaming
PO2TSIOS on  having to figure out those issues. As Mihai says, it should become
more clear over time what the right situation is here (and maybe Alan's work
will help, actually).

On 2014/04/10 15:13:36, msarda wrote:

+class ProfileOAuth2TokenServiceIOSProvider;
+}
+#endif
+
 // An interface that needs to be supplied to the Signin component by its
 // embedder.
 class SigninClient {
  public:
   typedef base::Callback<void(const net::CanonicalCookie* cookie)>
       CookieChangedCallback;
 
   virtual ~SigninClient() {}
 
   // Gets the preferences associated with the client.
@@ skipping 20 matching lines @@
   // callback will be called only if it is not empty.
   // TODO(blundell): Eliminate this interface in favor of having core signin
   // code observe cookie changes once //chrome/browser/net has been
   // componentized.
   virtual void SetCookieChangedCallback(
       const CookieChangedCallback& callback) = 0;
 
   // Called when Google signin has succeeded.
   virtual void GoogleSigninSucceeded(const std::string& username,
                                      const std::string& password) {}
+
+#if defined(OS_IOS)
+  // TODO(msarda): http://crbug.com/358544 Remove this iOS specific code from
+  // the core SigninClient.
+  virtual ios::ProfileOAuth2TokenServiceIOSProvider* GetIOSProvider() = 0;
+#endif
 };
 
 #endif  // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_