Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 226643011: Split toolchain update and install lookup to make generation faster (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Split toolchain update and install lookup to make generation faster runhooks does toolchain update, saving relevant information to build/win_toolchain.json, and during generation this is loaded and used. This worked almost the same previously, however update was called at generation time and the .json was deleted after it was used. This speeds up generation time by a few seconds. (In preference to https://codereview.chromium.org/228093002/) R=dpranke@chromium.org BUG=360878 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262590

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : rename to Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -41 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M build/gyp_chromium View 1 chunk +1 line, -1 line 0 comments Download
M build/vs_toolchain.py View 1 2 3 chunks +56 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
scottmg
6 years, 8 months ago (2014-04-08 20:01:51 UTC) #1
Dirk Pranke
lgtm w/ a nit ... https://codereview.chromium.org/226643011/diff/20001/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/226643011/diff/20001/build/vs_toolchain.py#newcode119 build/vs_toolchain.py:119: def UpdateOnly(): Nit: It's ...
6 years, 8 months ago (2014-04-08 20:50:57 UTC) #2
scottmg
https://codereview.chromium.org/226643011/diff/20001/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/226643011/diff/20001/build/vs_toolchain.py#newcode119 build/vs_toolchain.py:119: def UpdateOnly(): On 2014/04/08 20:50:57, Dirk Pranke wrote: > ...
6 years, 8 months ago (2014-04-08 20:53:02 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 8 months ago (2014-04-08 20:53:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/226643011/40001
6 years, 8 months ago (2014-04-08 20:55:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/226643011/40001
6 years, 8 months ago (2014-04-09 00:29:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/226643011/40001
6 years, 8 months ago (2014-04-09 00:53:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/226643011/40001
6 years, 8 months ago (2014-04-09 01:03:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/226643011/40001
6 years, 8 months ago (2014-04-09 01:24:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/226643011/40001
6 years, 8 months ago (2014-04-09 01:36:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/226643011/40001
6 years, 8 months ago (2014-04-09 01:47:29 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 01:56:21 UTC) #12
Message was sent while issue was closed.
Change committed as 262590

Powered by Google App Engine
This is Rietveld 408576698