Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2266423003: Revert of Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed)

Created:
4 years, 4 months ago by sunyunjia
Modified:
4 years, 4 months ago
Reviewers:
tkent, majidvp, dtapuska
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the blocking touch handlers for the input[type=range] and add touch-action instead (patchset #25 id:480001 of https://codereview.chromium.org/2209773002/ ) Reason for revert: Broke windows test. See https://bugs.chromium.org/p/chromium/issues/detail?id=640150 Original issue's description: > Remove the blocking touch handlers for the input[type=range] element and add touch-action instead. > > In current implementation, the input[type=range] blocks browser's scrolling in all directions. > > After adding "touch-action: pan-y" with a passive event listener to the horizontal input[type=range], or "pan-x" to the vertical input[type=range], the slider will only consume pan in its direction and does not block scrolling on the other direction. > > This touch-action will be overridden if the user has already defined the touch-action. It will update if the slider changes to horizontal/vertical. > > BUG=584438 > > Committed: https://crrev.com/cb18694aff180e913277a346a37e74835935b37d > Cr-Commit-Position: refs/heads/master@{#413616} TBR=tkent@chromium.org,dtapuska@chromium.org,majidvp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584438

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
sunyunjia
Created Revert of Remove the blocking touch handlers for the input[type=range] and add touch-action instead
4 years, 4 months ago (2016-08-23 13:36:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266423003/1
4 years, 4 months ago (2016-08-23 13:37:01 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 13:37:03 UTC) #5
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698