Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2266403007: [Layout API] Use ownerLayoutItem() in ObjectPaintInvalidator (Closed)

Created:
4 years, 3 months ago by pilgrim_google
Modified:
4 years, 3 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use ownerLayoutItem() in ObjectPaintInvalidator Direct access to LayoutPart is deprecated and being removed soon. The replacement is LayoutPartItem, which routes methods through the new block layout API. (See linked crbug for details.) This means the ownerLayoutObject() method is also deprecated, to be replaced with ownerLayoutItem(). There are no functional changes. BUG=499321 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/130f12013737065f881ec73854b1acbca1e9e7a2 Cr-Commit-Position: refs/heads/master@{#414623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pilgrim_google
4 years, 3 months ago (2016-08-25 17:32:56 UTC) #3
eae
LGTM
4 years, 3 months ago (2016-08-25 18:41:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266403007/1
4 years, 3 months ago (2016-08-25 23:43:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 01:45:28 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 01:49:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/130f12013737065f881ec73854b1acbca1e9e7a2
Cr-Commit-Position: refs/heads/master@{#414623}

Powered by Google App Engine
This is Rietveld 408576698