Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2266403004: Fix FastAccessorToSmi CCTest to use ptr type (Closed)

Created:
4 years, 4 months ago by john.yan
Modified:
4 years, 4 months ago
Reviewers:
vogelheim, Alfonso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix FastAccessorToSmi CCTest to use ptr type The generated FastAccessorAssembler uses IntPtr Load Op to load from &flags. Therefore, flags should be a pointer type. This fixes big endian issue. R=peterssen@google.com, vogelheim@chromium.org BUG= Committed: https://crrev.com/abd32fb1c7c8ca6344abcf334b9459956c106565 Cr-Commit-Position: refs/heads/master@{#38873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-api-fast-accessor-builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
john.yan
PTAL
4 years, 4 months ago (2016-08-23 20:09:03 UTC) #2
vogelheim
lgtm Thanks for the fix!
4 years, 4 months ago (2016-08-24 16:37:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266403004/1
4 years, 4 months ago (2016-08-24 17:02:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 17:04:52 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 17:05:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abd32fb1c7c8ca6344abcf334b9459956c106565
Cr-Commit-Position: refs/heads/master@{#38873}

Powered by Google App Engine
This is Rietveld 408576698