Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2266353005: Punt touch UGI deprecation to M55 (Closed)

Created:
4 years, 4 months ago by Rick Byers
Modified:
4 years, 2 months ago
Reviewers:
dtapuska, foolip
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Punt touch UGI deprecation to M55 BUG=611981 Committed: https://crrev.com/538f6eff1bf948589b4e5ba58291405e9e19fbe3 Cr-Commit-Position: refs/heads/master@{#414175}

Patch Set 1 #

Patch Set 2 : Update expectations #

Patch Set 3 : Fix expectations again :-( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
Rick Byers
Dave, PTAL at this trivial patch
4 years, 4 months ago (2016-08-23 19:31:41 UTC) #3
dtapuska
lgtm
4 years, 4 months ago (2016-08-23 19:34:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266353005/1
4 years, 4 months ago (2016-08-23 19:35:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/279276)
4 years, 4 months ago (2016-08-23 21:15:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266353005/20001
4 years, 4 months ago (2016-08-23 21:28:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/285133)
4 years, 4 months ago (2016-08-23 22:50:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266353005/30001
4 years, 3 months ago (2016-08-24 17:21:49 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129096)
4 years, 3 months ago (2016-08-24 20:46:38 UTC) #21
Rick Byers
On 2016/08/24 20:46:38, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-08-24 21:03:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266353005/30001
4 years, 3 months ago (2016-08-24 21:04:54 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 3 months ago (2016-08-24 22:37:03 UTC) #26
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/538f6eff1bf948589b4e5ba58291405e9e19fbe3 Cr-Commit-Position: refs/heads/master@{#414175}
4 years, 3 months ago (2016-08-24 22:40:01 UTC) #28
foolip
M55 branch is here, time to punt again or remove? (This is the only one ...
4 years, 2 months ago (2016-10-10 08:17:09 UTC) #30
Rick Byers
4 years, 2 months ago (2016-10-12 02:04:14 UTC) #31
Message was sent while issue was closed.
On 2016/10/10 08:17:09, foolip wrote:
> M55 branch is here, time to punt again or remove? (This is the only one that
> slipped for M55.)

Ugh, sorry.  I'll punt again and send out an intent now for M56 (I can't come up
with any better way of getting the information).

Powered by Google App Engine
This is Rietveld 408576698