third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-recalcs-style.html - Issue 2266353004: Make Document::styleForElementIgnoringPendingStyleSheets() be aware of a flat tree structure

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-recalcs-style.html

Issue 2266353004: Make Document::styleForElementIgnoringPendingStyleSheets() be aware of a flat tree structure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-recalcs-style-expected.txt » ('j') | third_party/WebKit/LayoutTests/shadow-dom/css-style-inherit.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 <script>	5 <script>

6 function getColorProperty(id) {	6 function getColorProperty(id) {

7 return window.getComputedStyle(document.getElementById(id)).color;	7 return window.getComputedStyle(document.getElementById(id)).color;

8 }	8 }

9	9

10 function log(message) {	10 function log(message) {

(...skipping 10 matching lines...) Expand all Loading...
21 <span id="span-child"></span>	21 <span id="span-child"></span>

22 </div>	22 </div>

23 </div>	23 </div>

24 <script>	24 <script>

25 description("Tests to ensure that updating the select rule in projection causes style recalc.");	25 description("Tests to ensure that updating the select rule in projection causes style recalc.");

26	26

27 var sr = document.getElementById("host").createShadowRoot();	27 var sr = document.getElementById("host").createShadowRoot();

28 sr.innerHTML = '<style>div { color: blue }</style><div><content id="contentId" s elect="#div-child"></content></div>';	28 sr.innerHTML = '<style>div { color: blue }</style><div><content id="contentId" s elect="#div-child"></content></div>';

29	29

30 shouldBe('getColorProperty("div-child")', '"rgb(0, 0, 255)"');	30 shouldBe('getColorProperty("div-child")', '"rgb(0, 0, 255)"');

31 shouldBe('getColorProperty("span-child")', '"rgb(255, 0, 0)"');	31 shouldBe('getColorProperty("span-child")', '"rgb(0, 0, 0)"');
hayato 2016/08/23 11:50:26 This is a bug of the original test, which should b This is a bug of the original test, which should be updated. rune 2016/08/23 12:36:12 Is there a spec which talks about inheritance for Show quoted text On 2016/08/23 11:50:26, hayato wrote: > This is a bug of the original test, which should be updated. Is there a spec which talks about inheritance for unassigned nodes? I'm not able to find anything. hayato 2016/08/24 03:34:58 Good point. http://w3c.github.io/webcomponents/sp Good point. http://w3c.github.io/webcomponents/spec/shadow/#flattening-algorithm should determine the parent in CSS inheritance. (The algorithm has been upstreamed to CSS Scoping: https://drafts.csswg.org/css-scoping/#flattening) For a host's child which is not assigned to any slot, I think there is no parent for that. rune 2016/08/24 12:38:44 Then shouldn't it return the empty string for comp Show quoted text On 2016/08/24 03:34:58, hayato wrote: > Good point. > > http://w3c.github.io/webcomponents/spec/shadow/#flattening-algorithm should > determine the parent in CSS inheritance. > (The algorithm has been upstreamed to CSS Scoping: > https://drafts.csswg.org/css-scoping/#flattening) > > For a host's child which is not assigned to any slot, I think there is no parent > for that. Then shouldn't it return the empty string for computed style like we do for nodes in detached subtrees? There was a discussion about the existence of computed style of detached trees on www-style in May. Don't think there was a conclusion for that issue, though.
32	32

33 sr.getElementById("contentId").select = "#span-child";	33 sr.getElementById("contentId").select = "#span-child";

34 shouldBe('getColorProperty("div-child")', '"rgb(255, 0, 0)"');	34 shouldBe('getColorProperty("div-child")', '"rgb(0, 0, 0)"');

35 shouldBe('getColorProperty("span-child")', '"rgb(0, 0, 255)"');	35 shouldBe('getColorProperty("span-child")', '"rgb(0, 0, 255)"');

36	36

37 if (window.testRunner)	37 if (window.testRunner)

38 testRunner.notifyDone();	38 testRunner.notifyDone();

39 </script>	39 </script>

40 </body>	40 </body>

41 </html>	41 </html>

OLD	NEW