third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc - Issue 2266313002: [layoutng] Create a more correct constraint space for children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2266313002: [layoutng] Create a more correct constraint space for children (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h ('k') | third_party/WebKit/Source/core/layout/ng/ng_units.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

index 1d024121b113a8a88dccf5697012c69c0bb4f095..f779374330cb556453abff10dbd803a747179ea3 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

@@ -18,6 +18,12 @@ NGConstraintSpace::NGConstraintSpace(NGLogicalSize container_size) {

block_fragmentation_type_ = FragmentNone;

}

+NGConstraintSpace::NGConstraintSpace(const NGConstraintSpace& other,

+ NGLogicalSize container_size)

+ : NGConstraintSpace(container_size) {

+ exclusions_ = other.exclusions_;

NGConstraintSpace NGConstraintSpace::fromLayoutObject(const LayoutBox& child) {

bool fixedInline = false, fixedBlock = false;

// XXX for orthogonal writing mode this is not right