Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/resources/md_extensions/detail_view.js

Issue 2266303002: [MD Extensions] Add the source type on the details page for an extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('extensions', function() { 5 cr.define('extensions', function() {
6 'use strict'; 6 'use strict';
7 7
8 var DetailView = Polymer({ 8 var DetailView = Polymer({
9 is: 'extensions-detail-view', 9 is: 'extensions-detail-view',
10 10
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 this.data.id, this.$$('#collect-errors').checked); 83 this.data.id, this.$$('#collect-errors').checked);
84 }, 84 },
85 85
86 /** 86 /**
87 * @param {!chrome.developerPrivate.DependentExtension} item 87 * @param {!chrome.developerPrivate.DependentExtension} item
88 * @private 88 * @private
89 */ 89 */
90 computeDependentEntry_: function(item) { 90 computeDependentEntry_: function(item) {
91 return loadTimeData.getStringF('itemDependentEntry', item.name, item.id); 91 return loadTimeData.getStringF('itemDependentEntry', item.name, item.id);
92 }, 92 },
93
94 /** @private */
95 computeSourceString_: function(item) {
michaelpg 2016/08/26 06:40:13 leave off the param for wildcard observers, or if
Devlin 2016/08/26 18:31:00 Done.
96 return extensions.getItemSourceString(
97 extensions.getItemSource(this.data));
98 }
93 }); 99 });
94 100
95 return {DetailView: DetailView}; 101 return {DetailView: DetailView};
96 }); 102 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698