Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2266253004: Include missing header files and update namespaces in browser test. (Closed)

Created:
4 years, 3 months ago by The one and only Dr. Crash
Modified:
4 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include missing header files and update namespaces in browser test. BUG=640282 TEST=browser tests Committed: https://crrev.com/a67c6f6ef8ba3d5130ef7cedd1dd34442bcb0e73 Cr-Commit-Position: refs/heads/master@{#413824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
The one and only Dr. Crash
4 years, 3 months ago (2016-08-23 19:03:44 UTC) #2
achuithb
lgtm
4 years, 3 months ago (2016-08-23 19:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266253004/1
4 years, 3 months ago (2016-08-23 19:09:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-23 20:10:47 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-23 20:12:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a67c6f6ef8ba3d5130ef7cedd1dd34442bcb0e73
Cr-Commit-Position: refs/heads/master@{#413824}

Powered by Google App Engine
This is Rietveld 408576698