Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/chromeos/display/display_preferences_unittest.cc

Issue 22662005: Don't remember best resolution. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/display/resolution_notification_controller_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/display/display_preferences_unittest.cc
diff --git a/chrome/browser/chromeos/display/display_preferences_unittest.cc b/chrome/browser/chromeos/display/display_preferences_unittest.cc
index 829995752b85443154d33d2b61e4a4a50779e969..6d0614d0f72ed7969c5ab729287e663cd467c174 100644
--- a/chrome/browser/chromeos/display/display_preferences_unittest.cc
+++ b/chrome/browser/chromeos/display/display_preferences_unittest.cc
@@ -190,7 +190,7 @@ TEST_F(DisplayPreferencesTest, BasicStores) {
ash::internal::DisplayManager* display_manager =
ash::Shell::GetInstance()->display_manager();
- UpdateDisplay("200x200*2,400x300");
+ UpdateDisplay("200x200*2, 400x300#400x400|300x200");
int64 id1 = gfx::Screen::GetNativeScreen()->GetPrimaryDisplay().id();
gfx::Display::SetInternalDisplayId(id1);
int64 id2 = ash::ScreenAsh::GetSecondaryDisplay().id();
@@ -271,7 +271,7 @@ TEST_F(DisplayPreferencesTest, BasicStores) {
EXPECT_FALSE(property->GetInteger("width", &width));
EXPECT_FALSE(property->GetInteger("height", &height));
- display_manager->SetDisplayResolution(id2, gfx::Size(400, 300));
+ display_manager->SetDisplayResolution(id2, gfx::Size(300, 200));
display_controller->SetPrimaryDisplayId(id2);
@@ -282,12 +282,13 @@ TEST_F(DisplayPreferencesTest, BasicStores) {
EXPECT_FALSE(property->GetInteger("width", &width));
EXPECT_FALSE(property->GetInteger("height", &height));
- // External dispaly's resolution must be stored this time.
+ // External dispaly's resolution must be stored this time because
+ // it's not best.
EXPECT_TRUE(properties->GetDictionary(base::Int64ToString(id2), &property));
EXPECT_TRUE(property->GetInteger("width", &width));
EXPECT_TRUE(property->GetInteger("height", &height));
- EXPECT_EQ(400, width);
- EXPECT_EQ(300, height);
+ EXPECT_EQ(300, width);
+ EXPECT_EQ(200, height);
// The layout remains the same.
EXPECT_TRUE(displays->GetDictionary(key, &layout_value));
@@ -331,12 +332,18 @@ TEST_F(DisplayPreferencesTest, BasicStores) {
EXPECT_TRUE(properties->GetDictionary(base::Int64ToString(id2), &property));
EXPECT_TRUE(property->GetInteger("width", &width));
EXPECT_TRUE(property->GetInteger("height", &height));
- EXPECT_EQ(400, width);
- EXPECT_EQ(300, height);
+ EXPECT_EQ(300, width);
+ EXPECT_EQ(200, height);
// Set new display's selected resolution.
- display_manager->SetDisplayResolution(id2 + 1, gfx::Size(500, 400));
- UpdateDisplay("200x200*2,500x400");
+ display_manager->RegisterDisplayProperty(id2 + 1,
+ gfx::Display::ROTATE_0,
+ 1.0f,
+ NULL,
+ gfx::Size(500, 400));
+
+ UpdateDisplay("200x200*2, 600x500#600x500|500x400");
+
// Update key as the 2nd display gets new id.
id2 = ash::ScreenAsh::GetSecondaryDisplay().id();
key = base::Int64ToString(id1) + "," + base::Int64ToString(id2);
@@ -362,14 +369,14 @@ TEST_F(DisplayPreferencesTest, BasicStores) {
TEST_F(DisplayPreferencesTest, PreventStore) {
ResolutionNotificationController::SuppressTimerForTest();
LoggedInAsUser();
- UpdateDisplay("400x300");
+ UpdateDisplay("400x300#500x400|400x300|300x200");
int64 id = ash::Shell::GetScreen()->GetPrimaryDisplay().id();
// Set display's resolution in single display. It creates the notification and
// display preferences should not stored meanwhile.
ash::Shell::GetInstance()->resolution_notification_controller()->
SetDisplayResolutionAndNotify(
id, gfx::Size(400, 300), gfx::Size(500, 400), base::Closure());
- UpdateDisplay("500x400");
+ UpdateDisplay("500x400#500x400|400x300|300x200");
const base::DictionaryValue* properties =
local_state()->GetDictionary(prefs::kDisplayProperties);
@@ -390,7 +397,7 @@ TEST_F(DisplayPreferencesTest, PreventStore) {
// by SetDisplayResolution.
ash::Shell::GetInstance()->display_manager()->SetDisplayResolution(
id, gfx::Size(300, 200));
- UpdateDisplay("300x200");
+ UpdateDisplay("300x200#500x400|400x300|300x200");
property = NULL;
EXPECT_TRUE(properties->GetDictionary(base::Int64ToString(id), &property));
« no previous file with comments | « ash/display/resolution_notification_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698