Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22662005: Don't remember best resolution. (Closed)

Created:
7 years, 4 months ago by oshima
Modified:
7 years, 4 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Don't remember best resolution. It's safe not to rely on the state to use best resolution. Reject unsupported resolution. BUG=none TEST=covered by test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217218

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : fix tests #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -43 lines) Patch
M ash/display/display_info.h View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M ash/display/display_info.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M ash/display/display_info_unittest.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M ash/display/display_manager.cc View 3 chunks +26 lines, -2 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 1 2 9 chunks +25 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 2 6 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
oshima
7 years, 4 months ago (2013-08-09 18:20:00 UTC) #1
Jun Mukai
lgtm
7 years, 4 months ago (2013-08-09 20:33:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/22662005/7001
7 years, 4 months ago (2013-08-09 21:05:03 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=144443
7 years, 4 months ago (2013-08-09 22:29:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/22662005/35001
7 years, 4 months ago (2013-08-12 04:06:19 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=144707
7 years, 4 months ago (2013-08-12 04:55:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/22662005/61001
7 years, 4 months ago (2013-08-12 16:56:06 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=20119
7 years, 4 months ago (2013-08-12 17:09:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/22662005/68001
7 years, 4 months ago (2013-08-12 17:11:33 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186769
7 years, 4 months ago (2013-08-13 02:53:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/22662005/68001
7 years, 4 months ago (2013-08-13 03:04:10 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 06:37:51 UTC) #12
Message was sent while issue was closed. 
Change committed as 217218

Powered by Google App Engine
This is Rietveld 408576698