Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2266183002: ash: Remove unnecessary checks for null ShelfWidget in ShelfLayoutManager (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Remove unnecessary checks for null ShelfWidget in ShelfLayoutManager The ShelfWidget exists for the lifetime of the ShelfLayoutManager. The ShelfLayoutManager is created in the ShelfWidget's constructor, and exists until the shelf container is destroyed at shutdown. Removing the checks makes the lifetimes easier to understand. BUG=615502 TEST=ash_unittests Committed: https://crrev.com/37b9e6da90be32a6e163dbbdf6accb983203eff5 Cr-Commit-Position: refs/heads/master@{#413543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
msw, please take a look.
4 years, 4 months ago (2016-08-22 20:36:42 UTC) #4
msw
lgtm
4 years, 4 months ago (2016-08-22 20:41:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266183002/1
4 years, 4 months ago (2016-08-22 21:38:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 21:46:54 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:48:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37b9e6da90be32a6e163dbbdf6accb983203eff5
Cr-Commit-Position: refs/heads/master@{#413543}

Powered by Google App Engine
This is Rietveld 408576698