Issue 226613007: Don't emit LDummyUse for ArgumentsObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226613007: Don't emit LDummyUse for ArgumentsObject. (Closed)

Created:
6 years, 8 months ago by Jarin

Modified:
6 years, 8 months ago

Reviewers:
yangguo, Michael Starzinger, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

There is no definition for HArgumentsObject, so LDummyUse confuses the register allocator. I have recently made similar fix for HCapturedObject (see https://codereview.chromium.org/222283002/). BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20663

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-no-dummy-use-for-arguments-object.js	View		1 chunk	+9 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Jarin

6 years, 8 months ago (2014-04-11 06:29:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20663 (presubmit successful).