Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2266123002: arc: Add the --arc-available switch (Closed)

Created:
4 years, 4 months ago by Luis Héctor Chávez
Modified:
4 years, 4 months ago
Reviewers:
achuithb, Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Add the --arc-available switch A previous change added a Chrome Variation to allow enabling ARC. This change adds another flag to ensure that the board Chrome is running on actually has the bits to enable it and avoid showing people the UI when it is not actually supported. BUG=633704 TEST=ARC still works Committed: https://crrev.com/49634287993d6b2efd137ddce7d4196e7ebc6fd1 Cr-Commit-Position: refs/heads/master@{#413908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Luis Héctor Chávez
PTAL achuith: chrome/browser/chromeos/, chromeos/ yusukes: components/arc
4 years, 4 months ago (2016-08-22 22:33:49 UTC) #6
achuithb
lgtm
4 years, 4 months ago (2016-08-22 22:46:31 UTC) #7
Yusuke Sato
lgtm
4 years, 4 months ago (2016-08-22 22:54:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266123002/1
4 years, 4 months ago (2016-08-23 23:17:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 00:36:36 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 00:38:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49634287993d6b2efd137ddce7d4196e7ebc6fd1
Cr-Commit-Position: refs/heads/master@{#413908}

Powered by Google App Engine
This is Rietveld 408576698