Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2266113002:
[Extensions] Prefix extension apis in the generation step (Closed)
|
Created:
4 years, 4 months ago by Devlin Modified:
4 years, 4 months ago Reviewers:
lazyboy CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Extensions] Prefix extension apis in the generation step
We prefix extension API types with the namespace of the API they are in
so that we can look them up easily. Right now, this is done at runtime
by traversing a dictionary value and modifying each of the values.
But since we generate all extension APIs with crbug.com/638758, we can
move this step into the generation, and avoid doing it at runtime.
BUG=638735
Committed: https://crrev.com/d0e853f951e0f59821d51003000d24cf9a4239a7
Cr-Commit-Position: refs/heads/master@{#413866}
Patch Set 1 : testfix #
Total comments: 8
Patch Set 2 : lazyboys #
Messages
Total messages: 36 (30 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== [Extensions] prefix gen BUG= ========== to ========== [Extensions] Prefix extension apis in the generation step We prefix extension API types with the namespace of the API they are in so that we can look them up easily. Right now, this is done at runtime by traversing a dictionary value and modifying each of the values. But since we generate all extension APIs with crbug.com/638758, we can move this step into the generation, and avoid doing it at runtime. BUG=638735 ==========
rdevlin.cronin@chromium.org changed reviewers: + lazyboy@chromium.org
lazyboy@, mind taking a look?
lgtm with nits. https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... File tools/json_schema_compiler/cpp_bundle_generator.py (right): https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:41: def _PrefixSchemaWithNamespace(schema): Add description, re: types and refs become fully qualified... https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:44: def prefix(obj, key, force_presence): nit: s/force_presence/mandatory https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:49: if obj[key].find('.') == -1: assert obj[key] is string? https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:53: for t in schema['types']: assert that schema['types'] is a list.
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:80001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... File tools/json_schema_compiler/cpp_bundle_generator.py (right): https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:41: def _PrefixSchemaWithNamespace(schema): On 2016/08/23 17:43:54, lazyboy wrote: > Add description, re: types and refs become fully qualified... Done. https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:44: def prefix(obj, key, force_presence): On 2016/08/23 17:43:55, lazyboy wrote: > nit: s/force_presence/mandatory Done. https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:49: if obj[key].find('.') == -1: On 2016/08/23 17:43:54, lazyboy wrote: > assert obj[key] is string? Done. https://codereview.chromium.org/2266113002/diff/60001/tools/json_schema_compi... tools/json_schema_compiler/cpp_bundle_generator.py:53: for t in schema['types']: On 2016/08/23 17:43:54, lazyboy wrote: > assert that schema['types'] is a list. Done.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org Link to the patchset: https://codereview.chromium.org/2266113002/#ps100001 (title: "lazyboys")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Extensions] Prefix extension apis in the generation step We prefix extension API types with the namespace of the API they are in so that we can look them up easily. Right now, this is done at runtime by traversing a dictionary value and modifying each of the values. But since we generate all extension APIs with crbug.com/638758, we can move this step into the generation, and avoid doing it at runtime. BUG=638735 ========== to ========== [Extensions] Prefix extension apis in the generation step We prefix extension API types with the namespace of the API they are in so that we can look them up easily. Right now, this is done at runtime by traversing a dictionary value and modifying each of the values. But since we generate all extension APIs with crbug.com/638758, we can move this step into the generation, and avoid doing it at runtime. BUG=638735 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [Extensions] Prefix extension apis in the generation step We prefix extension API types with the namespace of the API they are in so that we can look them up easily. Right now, this is done at runtime by traversing a dictionary value and modifying each of the values. But since we generate all extension APIs with crbug.com/638758, we can move this step into the generation, and avoid doing it at runtime. BUG=638735 ========== to ========== [Extensions] Prefix extension apis in the generation step We prefix extension API types with the namespace of the API they are in so that we can look them up easily. Right now, this is done at runtime by traversing a dictionary value and modifying each of the values. But since we generate all extension APIs with crbug.com/638758, we can move this step into the generation, and avoid doing it at runtime. BUG=638735 Committed: https://crrev.com/d0e853f951e0f59821d51003000d24cf9a4239a7 Cr-Commit-Position: refs/heads/master@{#413866} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d0e853f951e0f59821d51003000d24cf9a4239a7 Cr-Commit-Position: refs/heads/master@{#413866} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
