third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp - Issue 2266103002: Repaint when background switches painting from/to scrolling contents layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

Issue 2266103002: Repaint when background switches painting from/to scrolling contents layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

index cc06d4a84ffa768d2562263632f4bc878371f461..76574e79747c487f73602d2d85eac8fc0873ade6 100644

--- a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

+++ b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

@@ -225,7 +225,7 @@ void ObjectPaintInvalidator::setBackingNeedsPaintInvalidationInRect(const Layout

} else if (m_object.compositedScrollsWithRespectTo(paintInvalidationContainer)) {

layer.compositedLayerMapping()->setScrollingContentsNeedDisplayInRect(rect, reason, m_object);

} else if (paintInvalidationContainer.usesCompositedScrolling()) {

- if (layer.compositedLayerMapping()->shouldPaintBackgroundOntoScrollingContentsLayer()) {

+ if (layer.compositedLayerMapping()->backgroundPaintsOntoScrollingContentsLayer()) {

// TODO(flackr): Get a correct rect in the context of the scrolling contents layer to update

// rather than updating the entire rect.

const LayoutRect& scrollingContentsRect = toLayoutBox(m_object).layoutOverflowRect();