Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Issue 22661006: Make HAVE_MADV_FREE, HAVE_MADV_FREE_REUSE and HAVE_VIRTUALALLOC local macros as it only used in wtf… (Closed)

Created:
7 years, 4 months ago by ostap
Modified:
7 years, 4 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make HAVE_MADV_FREE, HAVE_MADV_FREE_REUSE and HAVE_VIRTUALALLOC local macros as it only used in wtf/TCSystemAlloc.h . HAVE_VIRTUALALLOC is compeletely removed per abarth comment: https://codereview.chromium.org/22661006/#msg5 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156423

Patch Set 1 #

Total comments: 1

Patch Set 2 : Deleted HAVE_VIRTUALALLOC and related code. #

Patch Set 3 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -127 lines) Patch
M Source/wtf/Platform.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/wtf/TCSystemAlloc.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M Source/wtf/TCSystemAlloc.cpp View 1 5 chunks +0 lines, -119 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ostap
7 years, 4 months ago (2013-08-11 07:31:16 UTC) #1
do-not-use
7 years, 4 months ago (2013-08-12 14:07:23 UTC) #2
do-not-use
The try bots are likely failing because you are not a committer yet. Unfortunately, it ...
7 years, 4 months ago (2013-08-12 17:40:58 UTC) #3
abarth-chromium
Done. Mr. Dumez, would you be willing to file an infrastructure crbug about not being ...
7 years, 4 months ago (2013-08-12 20:31:26 UTC) #4
abarth-chromium
https://codereview.chromium.org/22661006/diff/1/Source/wtf/TCSystemAlloc.h File Source/wtf/TCSystemAlloc.h (right): https://codereview.chromium.org/22661006/diff/1/Source/wtf/TCSystemAlloc.h#newcode73 Source/wtf/TCSystemAlloc.h:73: #define HAVE_VIRTUALALLOC 1 We don't use TC* on Window. ...
7 years, 4 months ago (2013-08-12 20:32:17 UTC) #5
eseidel
lgtm
7 years, 4 months ago (2013-08-15 21:13:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/22661006/11001
7 years, 4 months ago (2013-08-15 21:14:03 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/wtf/Platform.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 4 months ago (2013-08-15 21:14:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/22661006/18001
7 years, 4 months ago (2013-08-20 18:56:42 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 03:02:46 UTC) #10
Message was sent while issue was closed.
Change committed as 156423

Powered by Google App Engine
This is Rietveld 408576698