components/omnibox/browser/clipboard_url_provider.cc - Issue 2266083002: Avoid DCHECK failure for chrome:// URLs in autocomplete suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/clipboard_url_provider.cc

Issue 2266083002: Avoid DCHECK failure for chrome:// URLs in autocomplete suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes for pkasting@ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/autocomplete_result_unittest.cc ('k') | components/omnibox/browser/physical_web_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/clipboard_url_provider.cc

diff --git a/components/omnibox/browser/clipboard_url_provider.cc b/components/omnibox/browser/clipboard_url_provider.cc

index 93d497692b4caa61cde797ebc591a55b5271ec15..844443297309b14284ff216c0bb0b0ba29b14f2f 100644

--- a/components/omnibox/browser/clipboard_url_provider.cc

+++ b/components/omnibox/browser/clipboard_url_provider.cc

@@ -66,8 +66,5 @@ void ClipboardURLProvider::Start(const AutocompleteInput& input,

base::string16::npos, 0, match.description.length(),

ACMatchClassification::NONE, &match.description_class);

- // At least one match must be default, so if verbatim_match was invalid,

- // the clipboard match is allowed to be default.

- match.allowed_to_be_default_match = matches_.empty();

matches_.push_back(match);

}

« no previous file with comments | « components/omnibox/browser/autocomplete_result_unittest.cc ('k') | components/omnibox/browser/physical_web_provider.h » ('j') | no next file with comments »