components/omnibox/browser/autocomplete_controller.cc - Issue 2266083002: Avoid DCHECK failure for chrome:// URLs in autocomplete suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_controller.cc

Issue 2266083002: Avoid DCHECK failure for chrome:// URLs in autocomplete suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes for pkasting@ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc ('k') | components/omnibox/browser/autocomplete_result.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/autocomplete_controller.cc

diff --git a/components/omnibox/browser/autocomplete_controller.cc b/components/omnibox/browser/autocomplete_controller.cc

index 4dc3b39b04d033a8c2944548ba20196a55f80603..0082eb590fb2c0b8580dbd726deca365fe8a2f25 100644

--- a/components/omnibox/browser/autocomplete_controller.cc

+++ b/components/omnibox/browser/autocomplete_controller.cc

@@ -222,8 +222,8 @@ AutocompleteController::AutocompleteController(

}

if (provider_types & AutocompleteProvider::TYPE_PHYSICAL_WEB) {

- PhysicalWebProvider* physical_web_provider =

- PhysicalWebProvider::Create(provider_client_.get());

+ PhysicalWebProvider* physical_web_provider = PhysicalWebProvider::Create(

+ provider_client_.get(), history_url_provider_);

if (physical_web_provider)

providers_.push_back(physical_web_provider);

}