Avoid DCHECK failure for chrome:// URLs in autocomplete suggestions

components/omnibox/browser/physical_web_provider.h

Index: components/omnibox/browser/physical_web_provider.h
diff --git a/components/omnibox/browser/physical_web_provider.h b/components/omnibox/browser/physical_web_provider.h
index 86c1f5cba50ecad2d40fd464691bcdbf56112b60..3fac2bd189862ce2d5cc7f478d03d957dcd09da4 100644
--- a/components/omnibox/browser/physical_web_provider.h
+++ b/components/omnibox/browser/physical_web_provider.h
@@ -9,6 +9,7 @@
 #include "components/omnibox/browser/autocomplete_provider.h"
 
 class AutocompleteProviderClient;
+class HistoryURLProvider;
 
 namespace base {
 class ListValue;
@@ -16,14 +17,16 @@ class ListValue;
 
 class PhysicalWebProvider : public AutocompleteProvider {
 public:
-  static PhysicalWebProvider* Create(AutocompleteProviderClient* client);
+  static PhysicalWebProvider* Create(AutocompleteProviderClient* client,
+                                     HistoryURLProvider* history_url_provider);
 
   // AutocompleteProvider:
   void Start(const AutocompleteInput& input, bool minimal_changes) override;
   void Stop(bool clear_cached_results, bool due_to_user_inactivity) override;
 
 private:
-  PhysicalWebProvider(AutocompleteProviderClient* client);
+  PhysicalWebProvider(AutocompleteProviderClient* client,
+                      HistoryURLProvider* history_url_provider);
   ~PhysicalWebProvider() override;
 
   // Adds a separate match item to |matches_| for each nearby URL in
@@ -39,6 +42,9 @@ private:
   void AppendOverflowItem(int additional_url_count, int relevance);
 
   AutocompleteProviderClient* client_;
+
+  // Used for efficiency when creating the verbatim match.  Can be NULL.

[Peter Kasting, 2016/09/01 22:06:36]

Nit: NULL -> null

[mattreynolds, 2016/09/02 00:29:08]

Done.

+  HistoryURLProvider* history_url_provider_;
 };

[Peter Kasting, 2016/09/01 22:06:36]

Nit: DISALLOW_COPY_AND_ASSIGN.

[mattreynolds, 2016/09/02 00:29:08]

Done.

 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_