Avoid DCHECK failure for chrome:// URLs in autocomplete suggestions

components/omnibox/browser/autocomplete_result_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/autocomplete_result.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <vector>
@@ skipping 356 matching lines @@
     { 0, 1, 1300, true },
     { 0, 1, 1200, true },
   };
 
   ACMatches matches;
   PopulateAutocompleteMatches(data, arraysize(data), &matches);
   matches[1].destination_url = GURL();
   matches[3].destination_url = GURL();
   matches[4].destination_url = GURL();
 
-  AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
-                          GURL(), OmniboxEventProto::INVALID_SPEC, false, false,
+  AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
+                          std::string(), GURL(),
+                          OmniboxEventProto::INVALID_SPEC, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
   result.SortAndCull(input, template_url_service_.get());
 
   // Of the two results with the same non-empty destination URL, the
   // lower-relevance one should be dropped.  All of the results with empty URLs
   // should be kept.
   ASSERT_EQ(4U, result.size());
   EXPECT_TRUE(result.match_at(0)->destination_url.is_empty());
@@ skipping 23 matching lines @@
   };
 
   ACMatches matches;
   PopulateAutocompleteMatches(data, arraysize(data), &matches);
   matches[0].destination_url = GURL("http://www.foo.com/s?q=foo");
   matches[1].destination_url = GURL("http://www.foo.com/s?q=foo2");
   matches[2].destination_url = GURL("http://www.foo.com/s?q=foo&oq=f");
   matches[3].destination_url = GURL("http://www.foo.com/s?q=foo&aqs=0");
   matches[4].destination_url = GURL("http://www.foo.com/");
 
-  AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
-                          GURL(), OmniboxEventProto::INVALID_SPEC, false, false,
+  AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
+                          std::string(), GURL(),
+                          OmniboxEventProto::INVALID_SPEC, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
   result.SortAndCull(input, template_url_service_.get());
 
   // We expect the 3rd and 4th results to be removed.
   ASSERT_EQ(3U, result.size());
   EXPECT_EQ("http://www.foo.com/s?q=foo",
             result.match_at(0)->destination_url.spec());
   EXPECT_EQ(1300, result.match_at(0)->relevance);
@@ skipping 29 matching lines @@
 
   ACMatches matches;
   PopulateAutocompleteMatches(data, arraysize(data), &matches);
   matches[0].destination_url = GURL("http://www.foo.com/s?q=foo");
   matches[1].destination_url = GURL("http://www.foo.com/s?q=foo2");
   matches[2].destination_url = GURL("http://www.foo.com/s?q=foo&oq=f");
   matches[3].destination_url = GURL("http://www.foo.com/s?q=foo&aqs=0");
   matches[4].destination_url = GURL("http://www.foo.com/");
   matches[5].destination_url = GURL("http://www.foo.com/s?q=foo2&oq=f");
 
-  AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
-                          GURL(), OmniboxEventProto::INVALID_SPEC, false, false,
+  AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
+                          std::string(), GURL(),
+                          OmniboxEventProto::INVALID_SPEC, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
   result.SortAndCull(input, template_url_service_.get());
 
   // Expect 3 unique results after SortAndCull().
   ASSERT_EQ(3U, result.size());
 
   // Check that 3rd and 4th result got added to the first result as dups
   // and also duplicates of the 4th match got copied.
@@ skipping 31 matching lines @@
   {
     std::map<std::string, std::string> params;
     params[std::string(OmniboxFieldTrial::kDemoteByTypeRule) + ":3:*"] =
         "1:50,7:100,2:0";  // 3 == HOME_PAGE
     ASSERT_TRUE(variations::AssociateVariationParams(
         OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A", params));
   }
   base::FieldTrialList::CreateFieldTrial(
       OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A");
 
-  AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
-                          GURL(), OmniboxEventProto::HOME_PAGE, false, false,
+  AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
+                          std::string(), GURL(),
+                          OmniboxEventProto::HOME_PAGE, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
   result.SortAndCull(input, template_url_service_.get());
 
   // Check the new ordering.  The history-title results should be omitted.
   // We cannot check relevance scores because the matches are sorted by
   // demoted relevance but the actual relevance scores are not modified.
   ASSERT_EQ(3u, result.size());
   EXPECT_EQ("http://search-what-you-typed/",
@@ skipping 23 matching lines @@
     params[std::string(OmniboxFieldTrial::kDemoteByTypeRule) + ":8:*"] =
         "1:50";  // 8 == INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS
     ASSERT_TRUE(variations::AssociateVariationParams(
         OmniboxFieldTrial::kBundledExperimentFieldTrialName, "C", params));
   }
   base::FieldTrialList::CreateFieldTrial(
       OmniboxFieldTrial::kBundledExperimentFieldTrialName, "C");
 
   {
     AutocompleteInput input(
-        base::string16(), base::string16::npos, std::string(), GURL(),
+        base::ASCIIToUTF16("a"), base::string16::npos, std::string(), GURL(),
         OmniboxEventProto::INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS, false,
         false, false, true, false, TestSchemeClassifier());
     AutocompleteResult result;
     result.AppendMatches(input, matches);
     result.SortAndCull(input, template_url_service_.get());
 
     // The NAVSUGGEST dup-url stay above search-url since the navsuggest
     // variant should not be demoted.
     ASSERT_EQ(4u, result.size());
     EXPECT_EQ("http://search-what-you-typed/",
@@ skipping 16 matching lines @@
     { 2, 1, 1100, true },
     { 3, 1, 1000, true }
   };
 
   {
     // Check that reorder doesn't do anything if the top result
     // is already a legal default match (which is the default from
     // PopulateAutocompleteMatches()).
     ACMatches matches;
     PopulateAutocompleteMatches(data, arraysize(data), &matches);
-    AutocompleteInput input(base::string16(), base::string16::npos,
+    AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
                             std::string(), GURL(), OmniboxEventProto::HOME_PAGE,
                             false, false, false, true, false,
                             TestSchemeClassifier());

[Peter Kasting, 2016/09/01 22:06:35]

Nit: Consider pulling this temp out to where |data| is defined and using it in
both blocks.

[mattreynolds, 2016/09/02 00:29:08]

Done.

     AutocompleteResult result;
     result.AppendMatches(input, matches);
     result.SortAndCull(input, template_url_service_.get());
     AssertResultMatches(result, data, 4);
   }
 
   {
     // Check that reorder swaps up a result appropriately.
     ACMatches matches;
     PopulateAutocompleteMatches(data, arraysize(data), &matches);
     matches[0].allowed_to_be_default_match = false;
     matches[1].allowed_to_be_default_match = false;
-    AutocompleteInput input(base::string16(), base::string16::npos,
+    AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
                             std::string(), GURL(), OmniboxEventProto::HOME_PAGE,
                             false, false, false, true, false,
                             TestSchemeClassifier());
     AutocompleteResult result;
     result.AppendMatches(input, matches);
     result.SortAndCull(input, template_url_service_.get());
     ASSERT_EQ(4U, result.size());
     EXPECT_EQ("http://c/", result.match_at(0)->destination_url.spec());
     EXPECT_EQ("http://a/", result.match_at(1)->destination_url.spec());
     EXPECT_EQ("http://b/", result.match_at(2)->destination_url.spec());
@@ skipping 24 matching lines @@
   matches.clear();
 
   // Case 4: Standalone verbatim match found in AutocompleteResult.
   PopulateAutocompleteMatchesFromTestData(kVerbatimMatches, 1, &matches);
   PopulateAutocompleteMatchesFromTestData(kNonVerbatimMatches, 1, &matches);
   result.AppendMatches(AutocompleteInput(), matches);
   EXPECT_TRUE(result.TopMatchIsStandaloneVerbatimMatch());
   result.Reset();
   matches.clear();
 }