Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2266033002: Revert of Move parser pointer to CPDF_Document (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Move parser pointer to CPDF_Document (patchset #6 id:100001 of https://codereview.chromium.org/2253723002/ ) Reason for revert: Causing asan issues. See crbug.com/639451. Original issue's description: > Move parser pointer to CPDF_Document > > The CPDF_IndirectObjectHolder has two subclasses, CPDF_Document and > CFDF_Document. The CPDF document requires the parser and the CFDF document > does not. This cl moves the parser pointer up to CPDF_Document. > > Committed: https://pdfium.googlesource.com/pdfium/+/260f5fbf3553a96fa49b029cc050220039c30e2a TBR=tsepez@chromium.org,thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://pdfium.googlesource.com/pdfium/+/8d6c929d2605dc568beb73aab2c585622947fee2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -119 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 4 chunks +8 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 3 chunks +10 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 4 chunks +11 lines, -18 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp View 2 chunks +35 lines, -39 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 3 chunks +3 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_reference.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cfdf_document.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_document.h View 2 chunks +1 line, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h View 1 chunk +7 lines, -15 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_object.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
Created Revert of Move parser pointer to CPDF_Document
4 years, 4 months ago (2016-08-22 17:15:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266033002/1
4 years, 4 months ago (2016-08-22 17:15:09 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:24:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8d6c929d2605dc568beb73aab2c585622947...

Powered by Google App Engine
This is Rietveld 408576698