tools/build_command_buffer.py - Issue 2265913002: Build command buffer with is_component_build=false

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/build_command_buffer.py

Issue 2265913002: Build command buffer with is_component_build=false (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: build Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/build_command_buffer.py

diff --git a/tools/build_command_buffer.py b/tools/build_command_buffer.py

index 7dabafea1d67e6f1d7afe2dd6283c98a23fe56a4..08f76dba73d014b6374a4f2d7e9da7bc7cc66ddd 100755

--- a/tools/build_command_buffer.py

+++ b/tools/build_command_buffer.py

@@ -131,7 +131,8 @@ def main():

gn = 'gn.exe'

gn = os.path.join(chrome_src_dir, 'buildtools', platform, gn)

try:

- subprocess.check_call([gn, 'gen', chrome_target_dir_rel],

+ subprocess.check_call([gn, 'gen', chrome_target_dir_rel,

+ '--args=is_component_build=false'],

cwd=chrome_src_dir)

except subprocess.CalledProcessError as error:

sys.exit('Error (ret code: %s) calling "%s" in %s' % (

« no previous file with comments | « no previous file | no next file » | no next file with comments »