Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2265913002: Build command buffer with is_component_build=false (Closed)

Created:
4 years, 4 months ago by borenet2
Modified:
4 years, 4 months ago
Reviewers:
borenet, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/build_command_buffer.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
borenet
4 years, 4 months ago (2016-08-22 13:52:09 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-08-22 14:18:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265913002/20001
4 years, 4 months ago (2016-08-22 14:29:43 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 14:31:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a629166d6edf25ba39b3fe6ff1b749f0787df104

Powered by Google App Engine
This is Rietveld 408576698