Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2265903003: Move has_arguments_parameter_ to DeclarationScope (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move has_arguments_parameter_ to DeclarationScope BUG=v8:5209 Committed: https://crrev.com/83febb1d8d3abb0ad9b7aff4a371092ae2afe6f0 Cr-Commit-Position: refs/heads/master@{#38786}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : readd comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/ast/scopes.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/ast/scopes.cc View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-22 13:04:32 UTC) #2
neis
lgtm
4 years, 4 months ago (2016-08-22 13:22:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265903003/1
4 years, 4 months ago (2016-08-22 14:00:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/23127)
4 years, 4 months ago (2016-08-22 14:02:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265903003/40001
4 years, 4 months ago (2016-08-22 14:22:38 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-22 14:47:03 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 14:47:32 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/83febb1d8d3abb0ad9b7aff4a371092ae2afe6f0
Cr-Commit-Position: refs/heads/master@{#38786}

Powered by Google App Engine
This is Rietveld 408576698