media/cdm/ppapi/ppapi_cdm_adapter.cc - Issue 2265893003: media: Add UMA to report CDM interface version being used

Unified Diff: media/cdm/ppapi/ppapi_cdm_adapter.cc

Issue 2265893003: media: Add UMA to report CDM interface version being used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cdm/ppapi/ppapi_cdm_adapter.cc

diff --git a/media/cdm/ppapi/ppapi_cdm_adapter.cc b/media/cdm/ppapi/ppapi_cdm_adapter.cc

index d3a143a44aed157f8eee1474e0f6b74caacac6cd..bf0678f1b9209985cd46554c72ad46f6e94d852f 100644

--- a/media/cdm/ppapi/ppapi_cdm_adapter.cc

+++ b/media/cdm/ppapi/ppapi_cdm_adapter.cc

@@ -355,6 +355,13 @@ CdmWrapper* PpapiCdmAdapter::CreateCdmInstance(const std::string& key_system) {

DLOG_TO_CONSOLE(message);

CDM_DLOG() << message;

+ if (cdm) {

+ pp::UMAPrivate uma_interface(this);

+ uma_interface.HistogramEnumeration(

+ "Media.EME.CdmVersion", cdm->GetVersion(),

ddorwin 2016/08/22 20:38:15 Update this name too.

xhwang 2016/08/23 00:21:43 Done.

+ cdm::ContentDecryptionModule::kVersion + 1);

xhwang 2016/08/22 17:59:38 Just FYI: cdm::ContentDecryptionModule::kVersion i

ddorwin 2016/08/22 20:38:15 What is the +1 doing here? It might be worth comme

Ilya Sherman 2016/08/22 20:53:36 Could this be recorded as a sparse histogram?

xhwang 2016/08/22 21:51:22 This will be a very limited set. For now, it'll on

Ilya Sherman 2016/08/22 22:10:38 It's okay to use a dense histogram as long as the

xhwang 2016/08/23 00:21:43 Done.

xhwang 2016/08/23 00:21:43 This part is a bit confusing. The doc says that th

+ }

return cdm;

}

« media/cdm/cdm_wrapper.h ('K') | « media/cdm/cdm_wrapper.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')