memory_coordinator: Use component(target) instead of static_library(target)

memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which have "GLOBAL HIDDEN" visibility.

Committed: https://crrev.com/e8f2f416522d05887228f8f8011fd1d29e53116e
Cr-Commit-Position: refs/heads/master@{#413632}

[bashi, 2016-08-22 10:36:28]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 10:36:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-08-22 10:40:45]

Description was changed from

==========
Use "component(...)" in memory_coordinator
==========

to

==========
memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which are "GLOBAL HIDDEN" visibility.
==========

[bashi, 2016-08-22 10:46:10]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, tzik@chromium.org

[bashi, 2016-08-22 10:46:11]

PTAL

While I'm trying to add a static getter for MemoryCoordinator 
(https://codereview.chromium.org/2261073002/) I noticed a strange behavior which
is caused by unexpected visibility (two |g_memory_coordinator|s are defined in
the chrome binary). Using component() will solve the problem.

[bashi, 2016-08-22 10:49:39]

Description was changed from

==========
memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which are "GLOBAL HIDDEN" visibility.
==========

to

==========
memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which have "GLOBAL HIDDEN" visibility.
==========

[commit-bot: I haz the power, 2016-08-22 11:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 11:25:28]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[haraken, 2016-08-22 14:02:29]

LGTM

[bashi, 2016-08-22 23:02:57]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:03:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:34:47]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bashi, 2016-08-22 23:38:14]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:39:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 00:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:43:43]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[bashi, 2016-08-23 00:48:15]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-08-23 00:48:16]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2265893002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-08-23 00:48:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-08-23 01:37:52]

lgtm

[commit-bot: I haz the power, 2016-08-23 02:05:48]

Description was changed from

==========
memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which have "GLOBAL HIDDEN" visibility.
==========

to

==========
memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which have "GLOBAL HIDDEN" visibility.
==========

[commit-bot: I haz the power, 2016-08-23 02:05:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-23 02:07:18]

Description was changed from

==========
memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which have "GLOBAL HIDDEN" visibility.
==========

to

==========
memory_coordinator: Use component(target) instead of static_library(target)

Using component() will make sure that we don't define
unexpected symbols which have "GLOBAL HIDDEN" visibility.

Committed: https://crrev.com/e8f2f416522d05887228f8f8011fd1d29e53116e
Cr-Commit-Position: refs/heads/master@{#413632}
==========

[commit-bot: I haz the power, 2016-08-23 02:07:19]

Patchset 5 (id:??) landed as
https://crrev.com/e8f2f416522d05887228f8f8011fd1d29e53116e
Cr-Commit-Position: refs/heads/master@{#413632}