Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2265873005: VM: Remove more duplicate code between AOT and JIT compiler. (Closed)

Created:
4 years, 4 months ago by Florian Schneider
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove more duplicate code between AOT and JIT compiler. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8eaa762d4a565abeb84038a14a6274da9f4e37d5

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -582 lines) Patch
M runtime/vm/aot_optimizer.h View 3 chunks +0 lines, -19 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 chunk +0 lines, -256 lines 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph.h View 2 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 1 chunk +258 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/jit_optimizer.h View 3 chunks +0 lines, -19 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 2 chunks +0 lines, -282 lines 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 4 months ago (2016-08-22 20:24:57 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2265873005/diff/1/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/2265873005/diff/1/runtime/vm/flow_graph.cc#newcode2243 runtime/vm/flow_graph.cc:2243: // Tries to merge MathUnary operations, in this ...
4 years, 4 months ago (2016-08-22 21:55:39 UTC) #3
Florian Schneider
https://codereview.chromium.org/2265873005/diff/1/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/2265873005/diff/1/runtime/vm/flow_graph.cc#newcode2243 runtime/vm/flow_graph.cc:2243: // Tries to merge MathUnary operations, in this case ...
4 years, 4 months ago (2016-08-22 22:19:55 UTC) #4
Florian Schneider
4 years, 4 months ago (2016-08-22 22:20:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8eaa762d4a565abeb84038a14a6274da9f4e37d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698