Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/IDLExtendedAttributes.md ('k') | third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
index e8aa14eb7bfbc421616e0f1180fe69074075d76e..209ff49849b145515ee1a9a409446219d5668603 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
@@ -30,11 +30,9 @@ public:
static void traceActiveScriptWrappables(v8::Isolate*, ScriptWrappableVisitor*);
- virtual bool hasPendingActivity() const = 0;
-
+private:
ScriptWrappable* toScriptWrappable() const { return m_scriptWrappable; }
-private:
ScriptWrappable* m_scriptWrappable;
};
« no previous file with comments | « third_party/WebKit/Source/bindings/IDLExtendedAttributes.md ('k') | third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698