binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable.

third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index c1f74c4286e808879c9edb1af455d55690c9cafd..f3985f161c43ac3deb84ab1033e8e1aa97b8a0dd 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -116,7 +116,8 @@ public:
 
         v8::Local<v8::Object> wrapper = v8::Local<v8::Object>::New(m_isolate, v8::Persistent<v8::Object>::Cast(*value));
         ASSERT(V8DOMWrapper::hasInternalFieldsSet(wrapper));
-        if (toWrapperTypeInfo(wrapper)->hasPendingActivity(wrapper)) {
+        if (toWrapperTypeInfo(wrapper)->isActiveScriptWrappable()

[haraken, 2016/08/23 07:55:40]

Do we need to check isActiveScriptWrappable()? I'm assuming that if
isActiveScriptWrappable() is false,
toScriptWrappable(wrapper)->hasPendingActivity() will just return false.

Also can we add a DCHECK about the fact?

BTW, if we don't need to check isActiveScriptWrappable(), maybe can we entirely
remove [ActiveScriptWrappable]?

[Yuki, 2016/08/23 09:49:52]

Not necessary, but I'd expect isActiveScriptWrappable() is faster than
toScriptWrappable(wrapper)->hasPendingActivity() and isActiveScriptWrappable()
returns false for most cases.

I was afraid of a performance regression since the old implementation first
checked a similar thing.  If you think it should be okay, I'm fine to remove
isActiveScriptWrappable() check.
I've already added static_assert() in interface_base.cpp.  It verifies that, if
the interface does not have [ActiveScriptWrappable], hasPendingActivity() must
not be overridden, vice versa.
That's true, and it means there will be no way for the code generator to
recognize the interface as 'active', i.e. no way to check the followings.

1. [ASW] must accompany with [DependentLifetime].
2. [ASW] C++ class must inherit from ActiveScriptWrappable class.
3. non-[ASW] C++ class must not inherit from ActiveScriptWrappable class.
4. [ASW] C++ class must override hasPendingActivity().
5. non-[ASW] C++ class must not override hasPendingActivity().

See that this CL detected ImageCapture.idl and Sensor.idl were not specifying
[DependentLifetime], and a previous CL detected 3 IDLs were missing
[ActiveScriptWrappable].  It's better to keep it as is.

+            && toScriptWrappable(wrapper)->hasPendingActivity()) {
             v8::Persistent<v8::Object>::Cast(*value).MarkActive();
             return;
         }
@@ -161,11 +162,12 @@ public:
         ASSERT(V8DOMWrapper::hasInternalFieldsSet(wrapper));
 
         const WrapperTypeInfo* type = toWrapperTypeInfo(wrapper);
-        if (type->hasPendingActivity(wrapper)) {
+        if (type->isActiveScriptWrappable()
+            && toScriptWrappable(wrapper)->hasPendingActivity()) {
             // If you hit this assert, you'll need to add a [DependentiLifetime]
             // extended attribute to the DOM interface. A DOM interface that
             // overrides hasPendingActivity must be marked as [DependentLifetime].
-            RELEASE_ASSERT(!value->IsIndependent());
+            CHECK(!value->IsIndependent());
             m_isolate->SetObjectGroupId(*value, liveRootId());
             ++m_domObjectsWithPendingActivity;
         }
@@ -457,7 +459,8 @@ public:
         v8::Local<v8::Object> wrapper = v8::Local<v8::Object>::New(m_isolate, v8::Persistent<v8::Object>::Cast(*value));
         ASSERT(V8DOMWrapper::hasInternalFieldsSet(wrapper));
         // The ExecutionContext check is heavy, so it should be done at the last.
-        if (toWrapperTypeInfo(wrapper)->hasPendingActivity(wrapper)
+        if (toWrapperTypeInfo(wrapper)->isActiveScriptWrappable()
+            && toScriptWrappable(wrapper)->hasPendingActivity()
             // TODO(haraken): Currently we don't have a way to get a creation
             // context from a wrapper. We should implement the way and enable
             // the following condition.