third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h - Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/sensor/Sensor.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

index fdd2d3fae3fce6e8ca5045b7362a641b6ecf4030..995f4f37332b3d32c92d493c0065d2ba665f5fbd 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

@@ -63,6 +63,9 @@ public:

String state() const;

DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);

+ // ScriptWrappable overrides.

+ bool hasPendingActivity() const final;

// WebServiceWorkerProxy overrides.

void dispatchStateChangeEvent() override;

@@ -74,9 +77,6 @@ private:

static ServiceWorker* getOrCreate(ExecutionContext*, std::unique_ptr<WebServiceWorker::Handle>);

ServiceWorker(ExecutionContext*, std::unique_ptr<WebServiceWorker::Handle>);

- // ActiveScriptWrappable overrides.

- bool hasPendingActivity() const final;

// ActiveDOMObject overrides.

void stop() override;