Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 // EventTarget 149 // EventTarget
150 const AtomicString& interfaceName() const override; 150 const AtomicString& interfaceName() const override;
151 ExecutionContext* getExecutionContext() const override; 151 ExecutionContext* getExecutionContext() const override;
152 152
153 // ActiveDOMObject 153 // ActiveDOMObject
154 void suspend() override; 154 void suspend() override;
155 void resume() override; 155 void resume() override;
156 void stop() override; 156 void stop() override;
157 157
158 // ActiveScriptWrappable 158 // ScriptWrappable
159 // We keep the this object alive until either stopped or closed. 159 // We keep the this object alive until either stopped or closed.
160 bool hasPendingActivity() const final 160 bool hasPendingActivity() const final
161 { 161 {
162 return !m_closed && !m_stopped; 162 return !m_closed && !m_stopped;
163 } 163 }
164 164
165 DECLARE_VIRTUAL_TRACE(); 165 DECLARE_VIRTUAL_TRACE();
166 166
167 private: 167 private:
168 typedef Function<bool()> BoolFunction; 168 typedef Function<bool()> BoolFunction;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 215
216 bool m_stopped; 216 bool m_stopped;
217 bool m_closed; 217 bool m_closed;
218 218
219 bool m_hasDataChannels; // For RAPPOR metrics 219 bool m_hasDataChannels; // For RAPPOR metrics
220 }; 220 };
221 221
222 } // namespace blink 222 } // namespace blink
223 223
224 #endif // RTCPeerConnection_h 224 #endif // RTCPeerConnection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698