Adjust callers and networking delegates in net/ to modified APIs

net/url_request/url_request_simple_job_unittest.cc

Index: net/url_request/url_request_simple_job_unittest.cc
diff --git a/net/url_request/url_request_simple_job_unittest.cc b/net/url_request/url_request_simple_job_unittest.cc
index 64678a1ee31d00b2044c77982400f9cd87dcc161..1fa96abc7228325064ddc440d95329aff9da0d55 100644
--- a/net/url_request/url_request_simple_job_unittest.cc
+++ b/net/url_request/url_request_simple_job_unittest.cc
@@ -163,7 +163,7 @@ class URLRequestSimpleJobTest : public ::testing::Test {
 
 TEST_F(URLRequestSimpleJobTest, SimpleRequest) {
   StartRequest(NULL);
-  ASSERT_TRUE(request_->status().is_success());
+  EXPECT_EQ(OK, delegate_.request_status());
   EXPECT_EQ(kTestData, delegate_.data_received());
 }
 
@@ -178,7 +178,7 @@ TEST_F(URLRequestSimpleJobTest, RangeRequest) {
 
   StartRequest(&headers);
 
-  ASSERT_TRUE(request_->status().is_success());
+  EXPECT_EQ(OK, delegate_.request_status());
   EXPECT_EQ(kExpectedBody, delegate_.data_received());
 }
 
@@ -195,8 +195,7 @@ TEST_F(URLRequestSimpleJobTest, MultipleRangeRequest) {
   StartRequest(&headers);
 
   EXPECT_TRUE(delegate_.request_failed());
-  EXPECT_THAT(request_->status().error(),
-              IsError(ERR_REQUEST_RANGE_NOT_SATISFIABLE));
+  EXPECT_EQ(ERR_REQUEST_RANGE_NOT_SATISFIABLE, delegate_.request_status());
 }
 
 TEST_F(URLRequestSimpleJobTest, InvalidRangeRequest) {
@@ -207,7 +206,7 @@ TEST_F(URLRequestSimpleJobTest, InvalidRangeRequest) {
 
   StartRequest(&headers);
 
-  ASSERT_TRUE(request_->status().is_success());
+  EXPECT_EQ(OK, delegate_.request_status());
   EXPECT_EQ(kTestData, delegate_.data_received());
 }
 
@@ -215,7 +214,7 @@ TEST_F(URLRequestSimpleJobTest, EmptyDataRequest) {
   request_ =
       context_.CreateRequest(GURL("data:empty"), DEFAULT_PRIORITY, &delegate_);
   StartRequest(nullptr);
-  ASSERT_TRUE(request_->status().is_success());
+  EXPECT_EQ(OK, delegate_.request_status());
   EXPECT_EQ("", delegate_.data_received());
 }
 
@@ -226,7 +225,7 @@ TEST_F(URLRequestSimpleJobTest, CancelBeforeResponseStarts) {
   request_->Cancel();
 
   base::RunLoop().RunUntilIdle();
-  EXPECT_EQ(URLRequestStatus::CANCELED, request_->status().status());
+  EXPECT_EQ(ERR_ABORTED, delegate_.request_status());
   EXPECT_EQ(1, delegate_.response_started_count());
 }
 
@@ -244,7 +243,6 @@ TEST_F(URLRequestSimpleJobTest, CancelAfterFirstReadStarted) {
       FROM_HERE, base::Bind(&base::DoNothing), run_loop.QuitClosure()));
   run_loop.Run();
 
-  EXPECT_EQ(URLRequestStatus::CANCELED, request_->status().status());
   EXPECT_EQ(1, cancel_delegate.response_started_count());

[mmenke, 2016/09/01 16:57:26]

Why can't we check if the request was cancelled?  cancel_delegate subclasses
TestDelegate, so it should have its status set, right?

[maksims (do not use this acc), 2016/09/02 12:31:53]

Well, cancel_delegate overrides the OnReadCompleted method and has a
EXPECT_EQ(ERR_ABORTED, bytes_read) there. But to make in more obvious, I've
removed this method from this subclass and check the status normally, because
TestDelegate::OnReadCompleted will now set the status.

   EXPECT_EQ("", cancel_delegate.data_received());
   // Destroy the request so it doesn't outlive its delegate.