net/url_request/url_request_context_builder.cc - Issue 2265873002: Adjust callers and networking delegates in net/ to modified APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_context_builder.cc

Issue 2265873002: Adjust callers and networking delegates in net/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead

Patch Set: Matt's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_fetcher_core.cc ('K') | « net/url_request/url_fetcher_core.cc ('k') | net/url_request/url_request_data_job_fuzzer.cc » ('j') | net/url_request/url_request_file_dir_job_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_context_builder.cc

diff --git a/net/url_request/url_request_context_builder.cc b/net/url_request/url_request_context_builder.cc

index 4f3c3a9cdf60c5f24d02822c7942841429962124..7da35fcccd240e7beb3d346cd8cab5f0fd881495 100644

--- a/net/url_request/url_request_context_builder.cc

+++ b/net/url_request/url_request_context_builder.cc

@@ -94,9 +94,9 @@ class BasicNetworkDelegate : public NetworkDelegateImpl {

void OnBeforeRedirect(URLRequest* request,

const GURL& new_location) override {}

- void OnResponseStarted(URLRequest* request) override {}

+ void OnResponseStarted(URLRequest* request, int net_error) override {}

- void OnCompleted(URLRequest* request, bool started) override {}

+ void OnCompleted(URLRequest* request, bool started, int net_error) override {}

void OnURLRequestDestroyed(URLRequest* request) override {}